From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id 8HR/JfGiqWWIjAAA62LTzQ:P1 (envelope-from ) for ; Thu, 18 Jan 2024 23:15:13 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id 8HR/JfGiqWWIjAAA62LTzQ (envelope-from ) for ; Thu, 18 Jan 2024 23:15:13 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=elephly.net header.s=zoho header.b=PIGBy7V7; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=none; arc=pass ("zohomail.com:s=zohoarc:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1705616113; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=8NHldbpHD6yxmdXBIudboga7I4dlxmx4psgnxvt4j9U=; b=qglQSnoBMco545+KanIryn8nxw3yZvpgIQthqMsnxV4cebaL3rU8RLd+yI3n+nasCt3R6l kWF1A4Qm1yFabxEEOeyTHxafjnBF3S0/cA93rw6RRwnsd21fBE28K+OhYBFbckHEL5Y+A4 2TZbvPdgOewyUevMnh7MURftAJUuyL6gaSrimGsEySKant/HCTasQhqc3csyLPzwGDOyOD ad/UpTZYYk+A/qf4lkyigApk9N9Px5E2iWLKc/AgrBaT2KGwBi7+JifwSoSvnVADOJOqm6 tvtV7HpfokvqVq9j9i0/9OlGNBINryfspzklOXmXp0DJ41QQwXGzsd1KvDdNQQ== ARC-Authentication-Results: i=2; aspmx1.migadu.com; dkim=pass header.d=elephly.net header.s=zoho header.b=PIGBy7V7; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=none; arc=pass ("zohomail.com:s=zohoarc:i=1") ARC-Seal: i=2; s=key1; d=yhetil.org; t=1705616113; a=rsa-sha256; cv=pass; b=aCJxmU/zF0c0kGGd8AJowENrp9NGsBdbSLD1DZgZwBVKSua2RuwFBN9WYILSKIQSVaNt8Y 0OcKEbpho4cFF9HjZvWGTLBqra0xN5KlUKDrud+124Y2tbZcXwlIvPd3j4SVk0bc2fb91m U1XMn3+Syx6w+6gE2mwAgER6iuF3SKEGZmYOwr9K+C+y3zjVussZ7QXzt40VzO+Qevxk73 6ukfF5VJ6RliFYuG6d8OspctBqgxDXIqT+lMndKAiVAooJ/ckd+xz2gUd+dDacob8ZRY0J SUR5xTsPf3FiJeuaCSu1VbxVtCQuLiabGfa9xJKv2PxXgO8FfR9Ip/yxSgfTig== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 839CA13AB7 for ; Thu, 18 Jan 2024 23:15:13 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rQaej-0001ns-EE; Thu, 18 Jan 2024 17:14:37 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rQaeh-0001ne-Qc for guix-devel@gnu.org; Thu, 18 Jan 2024 17:14:35 -0500 Received: from sender3-of-o59.zoho.com ([136.143.184.59]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rQaef-000214-JL for guix-devel@gnu.org; Thu, 18 Jan 2024 17:14:35 -0500 ARC-Seal: i=1; a=rsa-sha256; t=1705616068; cv=none; d=zohomail.com; s=zohoarc; b=T2LEY6SUkooyM1SuSZRg5zDn/qgIOzjguph1Ly9wGvIIvceoaEvwN1cv6gsjW+qi5Lgu4uXT49cJxuqdKuLK4qjVZx0JCvT4wAzCHSoBuTEfVuYH4KskKsRqly36tX9fNtAITfEJhIrz5J3hynunL+DWL3unpNx1Z9HI69TqH+0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1705616068; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=8NHldbpHD6yxmdXBIudboga7I4dlxmx4psgnxvt4j9U=; b=iEzUmRNrBZOg3Og/WKzUVnonhJL8JIOs85ZGYwAh4B8yR08vmKs46u0jcKNBvoqqGb5j4SKJaJhOW9WzyXpW/ghWAtyFRzfvtexxldRTw5fEenicqAGsRE8Lze3UxIhOfEd2e+q4GDVpiW82n2Lp/ArPvy1CaTtsB/IgoWvI9So= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=elephly.net; spf=pass smtp.mailfrom=rekado@elephly.net; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1705616068; s=zoho; d=elephly.net; i=rekado@elephly.net; h=References:From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:In-reply-to:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=8NHldbpHD6yxmdXBIudboga7I4dlxmx4psgnxvt4j9U=; b=PIGBy7V73LQpayYORfIHQohZzB1kdLtvIHfZ8gY/QtKiHSmGxU/r5Ge4erLs5irZ FTiyRVt/J4MgWXiWmRN9LYL7NlypZIBfLqZp6Y65Da1BA2H9s7rU2uiNuRF3l3kTFN2 a3zRBA9DzZoR3d8TKmhCNLax7PbElZzgFtfbhk4M= Received: from localhost (103-108-142-46.pool.kielnet.net [46.142.108.103]) by mx.zohomail.com with SMTPS id 1705616066979348.80498285205; Thu, 18 Jan 2024 14:14:26 -0800 (PST) References: <170535805079.4223.16688886567369675491@vcs2.savannah.gnu.org> <20240115223414.D3725C405A2@vcs2.savannah.gnu.org> <87le8ml9v8.fsf@gmail.com> User-agent: mu4e 1.10.8; emacs 29.1 From: Ricardo Wurmus To: Maxim Cournoyer Cc: guix-devel@gnu.org Subject: Re: 07/07: gnu: Add python-docspec. Date: Thu, 18 Jan 2024 23:11:47 +0100 In-reply-to: <87le8ml9v8.fsf@gmail.com> Message-ID: <87fryuthkw.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-ZohoMailClient: External Received-SPF: pass client-ip=136.143.184.59; envelope-from=rekado@elephly.net; helo=sender3-of-o59.zoho.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -6.38 X-Migadu-Scanner: mx13.migadu.com X-Spam-Score: -6.38 X-Migadu-Queue-Id: 839CA13AB7 X-TUID: qrRKjjWaTkjl Hi Maxim, > I'm not in the Python team, but I thought I'd give some feedback on > recent Python packages added. > > guix-commits@gnu.org writes: > >> gnu: Add python-docspec. >>=20=20=20=20=20 >> * gnu/packages/python-xyz.scm (python-docspec): New variable. >>=20=20=20=20=20 >> Change-Id: I3103bde3483273a335156b38de742f493fd366f1 >> --- >> gnu/packages/python-xyz.scm | 25 +++++++++++++++++++++++++ >> 1 file changed, 25 insertions(+) >> >> diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm >> index 61958d5eac..58a1a2b3cd 100644 >> --- a/gnu/packages/python-xyz.scm >> +++ b/gnu/packages/python-xyz.scm >> @@ -622,6 +622,31 @@ Python dataclasses.") >> from JSON payloads using the @code{databind.core} framework.") >> (license license:expat))) >>=20=20 >> +(define-public python-docspec >> + (package >> + (name "python-docspec") >> + (version "2.2.1") >> + (source >> + (origin >> + (method url-fetch) >> + (uri (pypi-uri "docspec" version)) >> + (sha256 >> + (base32 "1zqmdrc6k8pprra8p3wpzq2ml2gph1cfjmsyg07f8b8fvizffm28")= ))) >> + (build-system pyproject-build-system) >> + (arguments (list #:tests? #false)) ;there are none > > This commit and a few others mention there are no tests; perhaps that's > true of the PyPI archive, but in this case it's worth fetching from Git > in my opinion to run the tests. Here for example, there appear to be a > Pytest test suite: > https://github.com/NiklasRosenstein/python-docspec/tree/develop/docspec/t= est > > Fetching from git and adding pytest no native-inputs may be enough to > have it run. > > Something to keep in mind for future submissions! Yes, I agree. These recent Python additions are a little special in that they had been misplaced and forgotten in the guix-science channel. I=E2=80=99ve recently taken some time to clean up the guix-science channel = and move things that don=E2=80=99t belong there to the default Guix channel, reviving and updating packages as I went along. It=E2=80=99s true that it would be a good idea to revisit these packages to check if we could get a test suite from the source repository and run it. --=20 Ricardo