From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id gLAUOK9SUWfcSAEA62LTzQ:P1 (envelope-from ) for ; Thu, 05 Dec 2024 07:13:52 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id gLAUOK9SUWfcSAEA62LTzQ (envelope-from ) for ; Thu, 05 Dec 2024 08:13:52 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="V+vqu/dV"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1733382831; a=rsa-sha256; cv=none; b=gRGUysJB787DIu6Xh1GxuDv4g7b3M6pg4ZCoipcRZJQ2AwqYVd9+jfjmqWm1QOw6gVkD6I cr32XTqsg0a0J9ohBmVH2cUVKIusXjQ5tQ2fpMczeDwTgXmtBVj1GLldw24uvwA0t/9cgn Q8BBRjVOmMw2bCs8CjXwQJLGgPaRbKvPNpNxOYifpJjUf4VZ8k6Ba4bpoN10r3WMDfHVLK NwgBrIpSuqdXvTvZkLMh1W+M1NMJGnCLMLvX2YuGAPZqBssigzaIPyVWN4vV0EbXy8ITGB sBfHV9k9jI3ZMMTwWdXgNTyIvG+W2vcBKYW7mtzvX2yTobGp41fjYkrCxWT7Ew== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="V+vqu/dV"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1733382831; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=hWUk32duX0FOs86j/+47rc0Qd3YUCjlNWXPuLh59FPM=; b=Emwmmng5M0acA9tV0/iLsf90NnPuatvOtffTPf1iNCDioLxJOMCPdFxmhcA8uI8/kjLI3q l7rualGl7eFvgXjXSS8omPCqzcHMqVnNtTRo2SDvS7v1/+V//jdQ4TT3MlfwFFUO2BZ2IT 7sGn1pdZrxRmJXT/sV+w/vh4MbDmy39bG8kZ+oOVlp+ldWlisYYAejerSsGa0/z6z7ya8Q 2+u/fTiHNYgJAgAkLrFZJ9W4iKBBnOEa0z9I5ccXvPtbvad1tdt0Ca5OAzSUyEaxYCSyK1 jJDwJIP0N3q3YpVUIiGWMbvd2D6vHL11xz9eKpMWajFEJAGMb5XT0/pFoeqDBQ== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B998F4E2A for ; Thu, 05 Dec 2024 08:13:51 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tJ634-0007oV-6H; Thu, 05 Dec 2024 02:13:18 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tJ630-0007n8-GW for guix-devel@gnu.org; Thu, 05 Dec 2024 02:13:14 -0500 Received: from mail-pl1-x62d.google.com ([2607:f8b0:4864:20::62d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tJ62y-0003Eg-Sp for guix-devel@gnu.org; Thu, 05 Dec 2024 02:13:14 -0500 Received: by mail-pl1-x62d.google.com with SMTP id d9443c01a7336-215666ea06aso14341825ad.0 for ; Wed, 04 Dec 2024 23:13:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1733382791; x=1733987591; darn=gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:to:from:from:to:cc:subject:date:message-id:reply-to; bh=hWUk32duX0FOs86j/+47rc0Qd3YUCjlNWXPuLh59FPM=; b=V+vqu/dVUN6YFZxWWzKFQz4vysNqFuSP8HSuh3pHwRJ0JuS53TGB0GH4APandoe/CE P77V8qhBajGJJeQOgkYs3V88uTffrAR0JyutruzCIELUiAi1Xfd5hF26/AQqHMdhZMVm a6KaMg2xlrVtBc2Q/PQnnP2CUrGul10K18etBDwNYY/83xUNK+BqsvnWzYM7h23Deycw qXTKpQ9pHqSN6u6OZ3NXiEEmo2RZw2+BkSk4iMmszaSY5cvRdVnvNJfPZGFXWNHcuuQO Ed3iJsslY4B2KzwU32HaJjBFvzy0cdOjlylI6qAcSphT+HZfYfZ43ZE1ahx7E8MhiXoX b2dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733382791; x=1733987591; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=hWUk32duX0FOs86j/+47rc0Qd3YUCjlNWXPuLh59FPM=; b=rJ1zftu0YU2f48GD9YZrOjjyOQhgpiZ6NpWhYGDzV69JP979eIXBg9LKnGJOdBhSe1 EnMesHwSdo/Hg2CE32P3IFR3V/eTpVTm9lxw9iwbdTjOIkyNOUrbtP8hE0QWB2BClEu/ K/x09LIVbCi3XhIrLD4Tw6dX6Om4GM3Xkg6Wng0bYmW2z15uBTCwpiU3+cgrn2jT31M/ gh/PpOuz0Z+XQDKxkXxGBHwUNYGFAb2+FhT765hbXzeU9tyj75Ic+vWooxD5vOC1wNmm htvNrJyQgc6Ad3KKzftMzFP0/DvbUS35RyYBzdzVabW4u5UAhxK5hM1qOZO072Jbr/wR Pe9w== X-Gm-Message-State: AOJu0YxeR2hXwoOEGoVn+5ZpQXYgV2fPdjVr/etlN7c6Ct2lEy2W6n31 4ZE9dYQHvfsyMi8bsQv24S1lNpnJgnM+NFVaP+tJQ7HHb3oWvAAqP50BqQ== X-Gm-Gg: ASbGnctx9XBfO1merZTkLu4ivkj4zmyv/0E5ptBwO+RMt9BXNPTqxtXR+5h0Y1vYX5g GD98BTztu3TCLYBQ6VvL/7JVscJioS6VhjvGOpx0YY/DhlWoJcBH+T0etExWVt8zmzRCRMm46Fg OMKCF6MZN6lcazEnASvqIEqI+j4YuIvEgrdee4Y/TZLCor9koh1vq8EjhcRnMuG1K/nUms7VaVr Hw3pD3FrOebK8sx9GQ3rSYk/daUUaWoD3Ts3a2uxRkaUco= X-Google-Smtp-Source: AGHT+IH0WjbE5SBWYV8MB1MSn9KZWJcZOLRw4ahHY+aemfV6YMXc/tf2eNGmswRRtD786SGMf1X9/Q== X-Received: by 2002:a17:902:ec90:b0:215:4f99:4ef5 with SMTP id d9443c01a7336-215f3ce8a3dmr35315535ad.28.1733382790521; Wed, 04 Dec 2024 23:13:10 -0800 (PST) Received: from terra ([2405:6586:be0:0:c8ff:1707:9b9:af89]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-215f8f29c17sm6263445ad.244.2024.12.04.23.13.09 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Dec 2024 23:13:10 -0800 (PST) From: Maxim Cournoyer To: guix-devel@gnu.org Subject: Re: Regarding the vertical alignment in the record definitions In-Reply-To: <87frn538q2.fsf@wolfsden.cz> (Tomas Volf's message of "Tue, 03 Dec 2024 01:34:29 +0100") References: <87frn538q2.fsf@wolfsden.cz> Date: Thu, 05 Dec 2024 16:13:00 +0900 Message-ID: <87frn2li0z.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::62d; envelope-from=maxim.cournoyer@gmail.com; helo=mail-pl1-x62d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Queue-Id: B998F4E2A X-Migadu-Scanner: mx13.migadu.com X-Migadu-Spam-Score: -9.37 X-Spam-Score: -9.37 X-TUID: KRU4jDWCLosd Hi Tomas, Tomas Volf <~@wolfsden.cz> writes: > Hello Guix, > > I would like to bring up for debate the convention the project has of > vertically aligning the record definitions. I don't think that's a project convention. It's more like it's a convention of some individual in the projects :-). At least I don't follow it, except sometimes when touching a piece of code already indented that way. > While some amount of noise in diffs is expected in any lisp language > (the trailing `)'), the vertical aligning makes it worse. It (in my > opinion) complicates both reviewing and re-basing (due to merge > conflicts). > > For example, take this patch I sent today. It adds *a single field* to > the record. However the patch (that someone needs to review and make > sure is correct) looks like this: I agree it's a bit tedious, both manually and also in diffs. My personal preference is to leave just one space between the field name and the value, that also holds for variable bounds in lets, etc., to avoid the problem (at the cost of some visual clarity, I guess). One day maybe we'll have a general tool like 'scheme-fmt' to run on a file save hook that'd fix the format question for good, like Python has with 'black' or 'ruff', etc. I have on mind to work on such a tool, but it's low in the list. -- Thanks, Maxim