From: ludo@gnu.org (Ludovic Courtès)
To: Manolis Ragkousis <manolis837@gmail.com>
Cc: Guix-devel@gnu.org
Subject: Re: [PATCH] gnu: autotools: Added autoconf-2.68 and turned autoconf-wrapper into a procedure
Date: Tue, 25 Mar 2014 00:02:43 +0100 [thread overview]
Message-ID: <87eh1rkxnw.fsf@gnu.org> (raw)
In-Reply-To: <CAFtzXzNLzqoJSSE94txLBSF+WEadey96T1_fRiiB561ivXJrkw@mail.gmail.com> (Manolis Ragkousis's message of "Mon, 24 Mar 2014 20:48:48 +0000")
Manolis Ragkousis <manolis837@gmail.com> skribis:
> From 27f0058e7842416b374d54cdd4f21c1c82433512 Mon Sep 17 00:00:00 2001
> From: Manolis Ragkousis <manolis837@gmail.com>
> Date: Mon, 24 Mar 2014 22:18:09 +0000
> Subject: [PATCH] gnu: autotools: Added autoconf-2.68 and turned
> autoconf-wrapper into a procedure
>
> * gnu/packages/autotools.scm (autoconf-2.68): Added autoconf-2.68 for use
> with the Hurd glibc.
> * gnu/packages/autotools.scm (autoconf-wrapper): Autoconf-wrapper takes
> 'autoconf-version' as an argument.
> * gnu/packages/autotools.scm (automake): Modify inputs to use the new form.
Thanks, applied with small changes (see below.)
I adjusted the commit log to follow GNU conventions.
> +(define-public (autoconf-wrapper autoconf-version)
> ;; An Autoconf wrapper that generates `configure' scripts that use our
> ;; own Bash instead of /bin/sh in shebangs. For that reason, it
> ;; should only be used internally---users should not end up
> ;; distributing `configure' files with a system-specific shebang.
> + ;; The "autoconf-version" is used to determine which version to use,
> + ;; in order to avoid duplication. If you want to use the latest version use
> + ;; ("autoconf" ,(autoconf-wrapper "autoconf")) as an input.
> (package (inherit autoconf)
> (location (source-properties->location (current-source-location)))
> (name (string-append (package-name autoconf) "-wrapper"))
> @@ -72,7 +89,9 @@ know anything about Autoconf or M4.")
> ;; XXX: Kludge to hide the circular dependency.
> ,(module-ref (resolve-interface '(gnu packages guile))
> 'guile-2.0))
> - ("autoconf" ,autoconf)
> + ("autoconf" ,(match autoconf-version
> + ("autoconf-2.68" autoconf-2.68)
> + ("autoconf" autoconf)))
Passing a version string is quite inelegant and fragile, so I changed
‘autoconf-wrapper’ to instead take a package object.
So:
(autoconf-wrapper)
returns a wrapper for the default ‘autoconf’ package, and:
(autoconf-wrapper autoconf-2.68)
returns a wrapper for that particular version.
Thanks,
Ludo’.
prev parent reply other threads:[~2014-03-24 23:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-24 20:48 [PATCH] gnu: autotools: Added autoconf-2.68 and turned autoconf-wrapper into a procedure Manolis Ragkousis
2014-03-24 23:02 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eh1rkxnw.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=Guix-devel@gnu.org \
--cc=manolis837@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).