From: ludo@gnu.org (Ludovic Courtès)
To: Sree Harsha Totakura <sreeharsha@totakura.in>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] Add (guix svn-download).
Date: Wed, 26 Mar 2014 17:00:03 +0100 [thread overview]
Message-ID: <87eh1p0x30.fsf@gnu.org> (raw)
In-Reply-To: <1395830163-27977-2-git-send-email-sreeharsha@totakura.in> (Sree Harsha Totakura's message of "Wed, 26 Mar 2014 11:36:03 +0100")
Sree Harsha Totakura <sreeharsha@totakura.in> skribis:
> * guix/svn-download.scm, guix/build/svn.scm: New files.
> * Makefile.am (MODULES): Add them.
Looks good to me!
Some comments:
> +(define* (svn-fetch url revision directory
> + #:key (svn-command "svn"))
> + "Fetch REVISION from URL into DIRECTORY. REVISION must be a valid svn
> +revision. Return #t on success, #f otherwise."
‘revision’ can/should be a number, no? Please augment the docstring to
say that, and...
> + (and (zero? (system* svn-command "checkout" "--non-interactive"
> + ;; Trust the server certificate. This is OK as we
> + ;; verify the checksum later. This can be removed when
> + ;; ca-certificates package is added.
> + "--trust-server-cert" "-r" revision url directory))
... possibly use (number->string revision) here ↑.
> +;;; Commentary:
> +;;;
> +;;; An <origin> method that fetches a specific revision from a Subversion
> +;;; repository. The repository URL and revision are specified with a
> +;;; <svn-reference> object.
> +;;;
> +;;; Code:
> +(define-record-type* <svn-reference>
> + svn-reference make-svn-reference
> + svn-reference?
> + (url svn-reference-url)
> + (revision svn-reference-revision))
Please align things, add a comment saying whether ‘revision’ is a number
or string, and add a newline before ‘define-record-type*’.
Thanks!
Ludo’.
next prev parent reply other threads:[~2014-03-26 16:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-26 10:36 Add svn-fetch method Sree Harsha Totakura
2014-03-26 10:36 ` [PATCH] Add (guix svn-download) Sree Harsha Totakura
2014-03-26 16:00 ` Ludovic Courtès [this message]
2014-03-26 16:59 ` Update patch: " Sree Harsha Totakura
2014-03-26 16:59 ` [PATCH] " Sree Harsha Totakura
2014-03-26 23:23 ` Ludovic Courtès
2014-03-27 9:30 ` Ludovic Courtès
2014-03-27 9:57 ` Sree Harsha Totakura
2014-03-27 10:17 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eh1p0x30.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=sreeharsha@totakura.in \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).