From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: gnome-doc-utils: Do not omit tests
Date: Sun, 22 Jun 2014 21:40:32 +0200
Message-ID: <87egygd973.fsf@gnu.org>
References: <1403422253-9505-1-git-send-email-jmd@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59005)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Wynd1-0003E1-Tv
	for guix-devel@gnu.org; Sun, 22 Jun 2014 15:40:44 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Wyncx-0005D6-C7
	for guix-devel@gnu.org; Sun, 22 Jun 2014 15:40:39 -0400
In-Reply-To: <1403422253-9505-1-git-send-email-jmd@gnu.org> (John Darrington's
	message of "Sun, 22 Jun 2014 09:30:53 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: John Darrington <jmd@gnu.org>
Cc: guix-devel@gnu.org

Hi!

John Darrington <jmd@gnu.org> skribis:

> * gnu/packages/gnome.scm (gnome-doc-utils): Added pre-check phase and do =
not
>   skip check phase

[...]

> +          ;; This stuff is needed, because without it, xmlint etc tries
> +          ;; to download docbookx.dtd and docbook.xsl from the net
> +          (let ((build (assoc-ref %standard-phases 'build))
> +                (docbook-xml (assoc-ref inputs "docbook-xml"))
> +                (docbook-xsl (assoc-ref inputs "docbook-xsl"))
> +                (our-catalog "/tmp/docbook-xml.xml"))
> +            (setenv "XML_CATALOG_FILES" our-catalog)
> +            (with-output-to-file our-catalog
> +              (lambda ()
> +                (display (string-append
> +                          "<?xml version=3D\"1.0\"?>
> +<!DOCTYPE catalog PUBLIC \"-//OASIS//DTD XML Catalogs V1.0//EN\"
> +\"file:///usr/share/xml/schema/xml-core/catalog.dtd\">
> +<catalog xmlns=3D\"urn:oasis:names:tc:entity:xmlns:xml:catalog\">
> +<system systemId=3D\"http://www.oasis-open.org/docbook/xml/4.4/docbookx.=
dtd\"
> +uri=3D\"file://" docbook-xml  "/xml/dtd/docbook/docbookx.dtd\"/>
> +<system systemId=3D\"http://docbook.sourceforge.net/release/xsl/current/=
manpages/docbook.xsl\"
> +uri=3D\"file://" docbook-xsl  "/xml/xsl/docbook-xsl-1.72.0/manpages/docb=
ook.xsl\"/>
> +</catalog>\n"))))))
> +        %standard-phases)))

Seems about time to discuss factorization.  :-)

Docbook-{XML,XSL} both provide a catalog.xml file.  Would it be enough
to set XML_CATALOG_FILES=3D/first/one/catalog.xml:/second/one/catalog.xml
rather than creating a new catalog.xml file that just points to them?

If the answer is yes, then we might be able to use the =E2=80=98search-path=
s=E2=80=99
mechanism to automatically populate $XML_CATALOG_FILES.

WDYT?

Ludo=E2=80=99.