From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH v2 2/2] guix package: add a "show" option.
Date: Fri, 18 Jul 2014 01:30:53 +0200
Message-ID: <87egxjbm1e.fsf@gnu.org>
References: <87r41mjozg.fsf@gnu.org>
	<1405558450-13602-1-git-send-email-tipecaml@gmail.com>
	<1405558450-13602-2-git-send-email-tipecaml@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57019)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1X7v8g-0007HD-G4
	for guix-devel@gnu.org; Thu, 17 Jul 2014 19:31:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1X7v8Z-0005iU-MD
	for guix-devel@gnu.org; Thu, 17 Jul 2014 19:31:02 -0400
Received: from hera.aquilenet.fr ([2a01:474::1]:60432)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1X7v8Z-0005iK-FA
	for guix-devel@gnu.org; Thu, 17 Jul 2014 19:30:55 -0400
In-Reply-To: <1405558450-13602-2-git-send-email-tipecaml@gmail.com> (Cyril
	Roelandt's message of "Thu, 17 Jul 2014 02:54:10 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Cyril Roelandt <tipecaml@gmail.com>
Cc: guix-devel@gnu.org

Cyril Roelandt <tipecaml@gmail.com> skribis:

> * doc/guix.texi: Update the documentation.
> * guix/scripts/package.scm: Add a "show" option.
> * tests/guix-package.sh: Add a test for the "show" option.

[...]

> +@item --show=3D@var{package}
> +Show details about a given package in @code{recutils} format (@pxref{Top=
, GNU

Rather: =E2=80=9CShow details about @var{package}, taken from the list of
available packages, in ...=E2=80=9D (to make it clear that it=E2=80=99s not=
 from the
list of installed packages.)

> --- a/tests/guix-package.sh
> +++ b/tests/guix-package.sh
> @@ -176,6 +176,9 @@ then false; else true; fi
>  # Check whether `--list-available' returns something sensible.
>  guix package -p "$profile" -A 'gui.*e' | grep guile
>=20=20
> +# Check whether `--show' returns something sensible.
> +guix package -p "$profile" --show=3Dguile | grep "^Package: guile"

=E2=80=98-p "$profile"=E2=80=99 can be omitted here.

OK to push with these changes, thanks!

Ludo=E2=80=99.