From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH] Emacs interface for Guix Date: Sat, 16 Aug 2014 11:27:19 +0200 Message-ID: <87egwgokco.fsf@gnu.org> References: <87k3719v7p.fsf@gmail.com> <87r419fa50.fsf@gnu.org> <87fvho9fqm.fsf@gmail.com> <87a97taixl.fsf@gmail.com> <87sil2rbly.fsf@gnu.org> <87tx5idn7f.fsf_-_@gmail.com> <87egwlkcy1.fsf@gnu.org> <87ppg5el2i.fsf@gmail.com> <87d2c5h4if.fsf@gnu.org> <87lhqsev1d.fsf@gmail.com> <877g2c74xh.fsf@gnu.org> <87ha1gds3w.fsf@gmail.com> <878umqe1wm.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:50067) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XIaGg-0008Qk-E1 for guix-devel@gnu.org; Sat, 16 Aug 2014 05:27:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XIaGf-0008OA-CH for guix-devel@gnu.org; Sat, 16 Aug 2014 05:27:22 -0400 Received: from hera.aquilenet.fr ([2a01:474::1]:35569) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XIaGf-0008O6-4q for guix-devel@gnu.org; Sat, 16 Aug 2014 05:27:21 -0400 In-Reply-To: <878umqe1wm.fsf@gmail.com> (Alex Kost's message of "Fri, 15 Aug 2014 09:51:21 +0400") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Alex Kost Cc: guix-devel@gnu.org Alex Kost skribis: > (define* (manifest-show-transaction manifest transaction #:key dry-run?) > "Display what will/would be installed/removed from MANIFEST by TRANSACT= ION." [...] > (format (current-error-port) > (N_ "The following package ~:[will~;would~] be ~a:~%~{~a= ~%~}~%" > "The following packages ~:[will~;would~] be ~a:~%~{~= a~%~}~%" > len) > dry-run? action-string package-strings))) [...] > (display-entries upgrade "upgraded (removed)") > (display-entries install "installed") > (display-entries remove "removed"))) Computed strings like impede correct internationalization. The whole sentences must be kept intact, to make sure people can translate them correctly. So that means repeating things a bit, but that=E2=80=99s unavoidable. > I tried to avoid the code duplicating, so it became more compact and > perhaps less readable. Also I added reporting about the packages to > upgrade: I thought as they are going to be replaced by the packages to > install, it is ok to add =E2=80=9C(removed)=E2=80=9D there. So an output= should look > like this (assuming "file-5.17" and "guile-2.0.9" are installed and are > being upgraded): > > The following packages will be upgraded (removed): > file-5.17 out /gnu/store/... > guile-2.0.9 out /gnu/store/... > > The following packages will be installed: > file-5.18 out > guile-2.0.11 out Ideally, I would just like to see: The following packages will be upgraded: file-5.17 out /gnu/store/... guile-2.0.9 out /gnu/store/... and not see them listed under =E2=80=9Cwill be installed.=E2=80=9D I would just keep the current messages for this patch series, and come up with an improved message format in a separate patch. WDYT? Thanks, Ludo=E2=80=99.