From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 1/4] gnu: Add potrace.
Date: Tue, 07 Oct 2014 23:26:59 +0200
Message-ID: <87egujvae4.fsf@gnu.org>
References: <87fvezx2di.fsf@member.fsf.org> <8738azx1cu.fsf@gnu.org>
	<87a957wzz7.fsf@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56142)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1XbcHd-0000Zc-Sp
	for guix-devel@gnu.org; Tue, 07 Oct 2014 17:27:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1XbcHY-0005vq-6x
	for guix-devel@gnu.org; Tue, 07 Oct 2014 17:27:01 -0400
Received: from hera.aquilenet.fr ([2a01:474::1]:50318)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1XbcHX-0005th-V7
	for guix-devel@gnu.org; Tue, 07 Oct 2014 17:26:56 -0400
In-Reply-To: <87a957wzz7.fsf@gmail.com> (Eric Bavier's message of "Tue, 07 Oct
	2014 12:29:00 -0500")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Eric Bavier <ericbavier@gmail.com>
Cc: guix-devel@gnu.org

Eric Bavier <ericbavier@gmail.com> skribis:

> Ludovic Court=C3=A8s writes:
>
>> Eric Bavier <ericbavier@gmail.com> skribis:
>>
>>> From f178a122f3805cbc23119b20c2144cf2a59bed3f Mon Sep 17 00:00:00 2001
>>> From: Eric Bavier <bavier@member.fsf.org>
>>> Date: Tue, 7 Oct 2014 11:13:35 -0500
>>> Subject: [PATCH 1/4] gnu: Add potrace.
>>>
>>> * gnu/packages/fontutils.scm (potrace): New variable.
>>
>> This part looks good to me, but...
>
> Ok.
>
>>
>>>  gnu/packages/fontutils.scm |   28 ++++++++++++++
>>>  gnu/packages/giflib.scm    |   90 ++++++++++++++++++++++++++++++++++++=
++++++++
>>
>> What about the giflib.scm changes?  Were they intended?
>
> No, those changes were not intended.

OK.

>> Perhaps giflib 5.x can be added in image.scm?
>
> I was experimenting with the latest version of fontforge, which can use
> giflib 5.x.  For the time being it can be left out.
>
> An updated patch is attached.
>
>
> From 6721d6e9e31af8aff5e781d813e55347dea378c9 Mon Sep 17 00:00:00 2001
> From: Eric Bavier <bavier@member.fsf.org>
> Date: Tue, 7 Oct 2014 12:27:37 -0500
> Subject: [PATCH] gnu: Add potrace.
>
> * gnu/packages/fontutils.scm (potrace): New variable.

LGTM!

Ludo'.