unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Mark H Weaver <mhw@netris.org>
To: John Darrington <jmd@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add ntp
Date: Sat, 18 Oct 2014 12:24:56 -0400	[thread overview]
Message-ID: <87egu5qraf.fsf@yeeloong.lan> (raw)
In-Reply-To: <1413645106-14116-1-git-send-email-jmd@gnu.org> (John Darrington's message of "Sat, 18 Oct 2014 17:11:46 +0200")

John Darrington <jmd@gnu.org> writes:

> +(define-public ntp
> +  (package
> +   (name "ntp")
> +   (version "4.2.6p5")
> +   (source (origin
> +	    (method url-fetch)
> +	    (uri (string-append "http://www.eecis.udel.edu/~ntp/ntp_spool/ntp4/ntp-"
> +                                (string-take version 3) "/ntp-" 

Instead of 'string-take', please import (srfi srfi-1) and then do this:

  (string-join (take (string-split version #\.) 2)
               ".")

We use this pattern in a number of other places -- search for
"string-join" in gnu/packages/*.scm to find them.  I suppose we should
add a procedure specifically for this, but it can wait, and it should be
in a separate commit anyway.

> +                                version ".tar.gz"))
> +	    (sha256
> +	     (base32
> +	      "077r69a41hasl8zf5c44km7cqgfhrkaj6a4jnr75j7nkz5qq7ayn"))))
> +   (native-inputs `(("which" ,which)))
> +   (build-system gnu-build-system)
> +   (synopsis "Real time clock synchonization system")
> +   (description "NTP is a system designed to synchronize the clocks of
> +computers over a network.")
> +   (license (x11-style 
> +             "http://www.eecis.udel.edu/~mills/ntp/html/copyright.html"
> +             "A non-copyleft free licence from the University of Delaware"))
> +   (home-page "http://www.ntp.org")))

Okay to commit with the change above.

    Thanks!
      Mark

  reply	other threads:[~2014-10-18 16:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-18 15:11 [PATCH] gnu: Add ntp John Darrington
2014-10-18 16:24 ` Mark H Weaver [this message]
2014-10-18 18:08   ` Ian Denhardt
2014-10-18 22:03     ` Mark H Weaver

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87egu5qraf.fsf@yeeloong.lan \
    --to=mhw@netris.org \
    --cc=guix-devel@gnu.org \
    --cc=jmd@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).