[PATCH 0/2] Improve search path handling?

[PATCH 0/2] Improve search path handling?

[David Thompson]

While hacking on Ruby stuff, I noticed that executable files in Ruby
gems aren't installed in 'bin', but rather 'lib/ruby/gems/2.2.0/bin'.
In order to make these executables "just work", I decided to add a
search path specification for $PATH to the ruby package.  That's when I
noticed an issue: 'guix package --search-paths' would have me clobber
the $PATH I had already configured to use my profile.

    export PATH="/home/dave/.guix-profile/lib/ruby/gems/2.2.0/bin"

To solve this, two things need to happen: A default $PATH with 'bin' and
'sbin' needs to be included, and search path specifications that have
the same variable name need to be merged.

The merge is necessary to avoid a situation like this:

    export PATH="/home/dave/.guix-profile/bin:/home/dave/.guix-profile/sbin"
    export PATH="/home/dave/.guix-profile/lib/ruby/gems/2.2.0/bin"

I also tweaked 'guix environment' to use the base search paths, which it
was already doing, but via a hardcoded search path specification.

Or maybe this is all silly and I'm doing it wrong!  You decide!

Thanks in advance for the patch review.

-- 
David Thompson
Web Developer - Free Software Foundation - http://fsf.org
GPG Key: 0FF1D807
Support the FSF: https://fsf.org/donate

[PATCH 1/2] packages: Merge like search path specifications.

[David Thompson]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: 0001-packages-Merge-like-search-path-specifications.patch --]
[-- Type: text/x-diff, Size: 3488 bytes --]

From 3f72a5d1cfe6d65f54c50c2ac8a8dd31f1a0691f Mon Sep 17 00:00:00 2001
From: David Thompson <dthompson2@worcester.edu>
Date: Mon, 23 Feb 2015 20:36:59 -0500
Subject: [PATCH 1/2] packages: Merge like search path specifications.

* guix/packages.scm (merge-search-path-specifications): New procedure.
* guix/scripts/packages.scm (search-path-environment-variables): Merge search
  paths before displaying them.
---
 guix/packages.scm        | 28 ++++++++++++++++++++++++++++
 guix/scripts/package.scm |  7 ++++---
 2 files changed, 32 insertions(+), 3 deletions(-)

diff --git a/guix/packages.scm b/guix/packages.scm
index 5b686a1..3e0574a 100644
--- a/guix/packages.scm
+++ b/guix/packages.scm
@@ -54,6 +54,7 @@
             search-path-specification
             search-path-specification?
             search-path-specification->sexp
+            merge-search-path-specifications
 
             package
             package?
@@ -203,6 +204,33 @@ corresponds to the arguments expected by `set-path-environment-variable'."
     (($ <search-path-specification> variable files separator type pattern)
      `(,variable ,files ,separator ,type ,pattern))))
 
+(define (merge-search-path-specifications specs)
+  "Merge the elements of SPECS, a list of search path specifications, by
+combining the ones that represent the same environment variable."
+  (match specs
+    (() '())
+    (((? search-path-specification? spec) . tail)
+     (let-values (((dupes others)
+                   ;; Separate duplicate variables from the remainder of
+                   ;; the list.
+                   (partition
+                    (lambda (other-spec)
+                      (string=?
+                       (search-path-specification-variable spec)
+                       (search-path-specification-variable other-spec)))
+                    tail)))
+       (cons (fold (lambda (dupe memo)
+                     ;; Assuming separator, type, and pattern are the same
+                     ;; since the environment variable names match.
+                     (search-path-specification (inherit memo)
+                      (files (delete-duplicates
+                              (append
+                               (search-path-specification-files memo)
+                               (search-path-specification-files dupe))))))
+                   spec
+                   dupes)
+             (merge-search-path-specifications others))))))
+
 (define %supported-systems
   ;; This is the list of system types that are supported.  By default, we
   ;; expect all packages to build successfully here.
diff --git a/guix/scripts/package.scm b/guix/scripts/package.scm
index fc116d8..da95d45 100644
--- a/guix/scripts/package.scm
+++ b/guix/scripts/package.scm
@@ -393,9 +393,10 @@ current settings and report only settings not already effective."
                       (string-join path separator)))))))
 
     (let* ((packages     (filter-map manifest-entry->package entries))
-           (search-paths (delete-duplicates
-                          (append-map package-native-search-paths
-                                      packages))))
+           (search-paths (merge-search-path-specifications
+                          (delete-duplicates
+                           (append-map package-native-search-paths
+                                       packages)))))
       (filter-map search-path-definition search-paths))))
 
 (define (display-search-paths entries profile)
-- 
2.1.4


[-- Attachment #2: Type: text/plain, Size: 136 bytes --]


-- 
David Thompson
Web Developer - Free Software Foundation - http://fsf.org
GPG Key: 0FF1D807
Support the FSF: https://fsf.org/donate

Re: [PATCH 1/2] packages: Merge like search path specifications.

[Ludovic Courtès]

David Thompson <dthompson2@worcester.edu> skribis:

> From 3f72a5d1cfe6d65f54c50c2ac8a8dd31f1a0691f Mon Sep 17 00:00:00 2001
> From: David Thompson <dthompson2@worcester.edu>
> Date: Mon, 23 Feb 2015 20:36:59 -0500
> Subject: [PATCH 1/2] packages: Merge like search path specifications.
>
> * guix/packages.scm (merge-search-path-specifications): New procedure.
> * guix/scripts/packages.scm (search-path-environment-variables): Merge search
>   paths before displaying them.

Could you add a test case?  Otherwise LGTM, and surely a good idea.

Thanks,
Ludo’.

[PATCH 2/2] packages: Add %base-search-path-specifications.

[David Thompson]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: 0002-packages-Add-base-search-path-specifications.patch --]
[-- Type: text/x-diff, Size: 3425 bytes --]

From cdc378a6fb6a59e49511d4151e0f2ba79e502632 Mon Sep 17 00:00:00 2001
From: David Thompson <dthompson2@worcester.edu>
Date: Mon, 23 Feb 2015 20:45:59 -0500
Subject: [PATCH 2/2] packages: Add %base-search-path-specifications.

* guix/packages.scm (%base-search-path-specifications): New variable.
* guix/scripts/package.scm (search-path-environment-variables): Append base
  search paths to package search paths.
* guix/scripts/environment.scm (for-each-search-path): Factor out hardcoded
  search path.
---
 guix/packages.scm            | 6 ++++++
 guix/scripts/environment.scm | 8 +++-----
 guix/scripts/package.scm     | 7 ++++---
 3 files changed, 13 insertions(+), 8 deletions(-)

diff --git a/guix/packages.scm b/guix/packages.scm
index 3e0574a..0804247 100644
--- a/guix/packages.scm
+++ b/guix/packages.scm
@@ -53,6 +53,7 @@
             <search-path-specification>
             search-path-specification
             search-path-specification?
+            %base-search-path-specifications
             search-path-specification->sexp
             merge-search-path-specifications
 
@@ -197,6 +198,11 @@ representation."
   (file-pattern search-path-specification-file-pattern ;#f | string
                 (default #f)))
 
+(define %base-search-path-specifications
+  (list (search-path-specification
+         (variable "PATH")
+         (files (list "bin" "sbin")))))
+
 (define (search-path-specification->sexp spec)
   "Return an sexp representing SPEC, a <search-path-specification>.  The sexp
 corresponds to the arguments expected by `set-path-environment-variable'."
diff --git a/guix/scripts/environment.scm b/guix/scripts/environment.scm
index bb2ce53..237cefa 100644
--- a/guix/scripts/environment.scm
+++ b/guix/scripts/environment.scm
@@ -56,11 +56,9 @@ path value is appended."
                         (if (and current (not pure?))
                             (string-append value separator current)
                             value)))))
-              (cons* (search-path-specification
-                      (variable "PATH")
-                      (files '("bin" "sbin")))
-                     (delete-duplicates
-                      (append-map package-native-search-paths inputs))))))
+              (append %base-search-path-specifications
+                      (delete-duplicates
+                       (append-map package-native-search-paths inputs))))))
 
 ;; Protect some env vars from purification.  Borrowed from nix-shell.
 (define %precious-variables
diff --git a/guix/scripts/package.scm b/guix/scripts/package.scm
index da95d45..e5c7354 100644
--- a/guix/scripts/package.scm
+++ b/guix/scripts/package.scm
@@ -394,9 +394,10 @@ current settings and report only settings not already effective."
 
     (let* ((packages     (filter-map manifest-entry->package entries))
            (search-paths (merge-search-path-specifications
-                          (delete-duplicates
-                           (append-map package-native-search-paths
-                                       packages)))))
+                          (append %base-search-path-specifications
+                                  (delete-duplicates
+                                   (append-map package-native-search-paths
+                                               packages))))))
       (filter-map search-path-definition search-paths))))
 
 (define (display-search-paths entries profile)
-- 
2.1.4


[-- Attachment #2: Type: text/plain, Size: 136 bytes --]


-- 
David Thompson
Web Developer - Free Software Foundation - http://fsf.org
GPG Key: 0FF1D807
Support the FSF: https://fsf.org/donate

Re: [PATCH 2/2] packages: Add %base-search-path-specifications.

[Ludovic Courtès]

David Thompson <dthompson2@worcester.edu> skribis:

> From cdc378a6fb6a59e49511d4151e0f2ba79e502632 Mon Sep 17 00:00:00 2001
> From: David Thompson <dthompson2@worcester.edu>
> Date: Mon, 23 Feb 2015 20:45:59 -0500
> Subject: [PATCH 2/2] packages: Add %base-search-path-specifications.
>
> * guix/packages.scm (%base-search-path-specifications): New variable.
> * guix/scripts/package.scm (search-path-environment-variables): Append base
>   search paths to package search paths.
> * guix/scripts/environment.scm (for-each-search-path): Factor out hardcoded
>   search path.

LGTM!

Ludo'.

Re: [PATCH 0/2] Improve search path handling?

[David Thompson]

David Thompson <dthompson2@worcester.edu> writes:

> While hacking on Ruby stuff, I noticed that executable files in Ruby
> gems aren't installed in 'bin', but rather 'lib/ruby/gems/2.2.0/bin'.
> In order to make these executables "just work", I decided to add a
> search path specification for $PATH to the ruby package.  That's when I
> noticed an issue: 'guix package --search-paths' would have me clobber
> the $PATH I had already configured to use my profile.
>
>     export PATH="/home/dave/.guix-profile/lib/ruby/gems/2.2.0/bin"
>
> To solve this, two things need to happen: A default $PATH with 'bin' and
> 'sbin' needs to be included, and search path specifications that have
> the same variable name need to be merged.
>
> The merge is necessary to avoid a situation like this:
>
>     export PATH="/home/dave/.guix-profile/bin:/home/dave/.guix-profile/sbin"
>     export PATH="/home/dave/.guix-profile/lib/ruby/gems/2.2.0/bin"
>
> I also tweaked 'guix environment' to use the base search paths, which it
> was already doing, but via a hardcoded search path specification.
>
> Or maybe this is all silly and I'm doing it wrong!  You decide!

Found one big issue with adding a $PATH search path specification to a
package: It messes up the 'set-paths' phase of 'gnu-build-system'.
$PATH ends up being unset!

    environment variable `PATH' set to `/gnu/store/dwjlh4id7ksdjiigfddw5dq617bajxxm-ruby-2.2.0/bin:/gnu/store/cdgpj8djhvfwsysa0bklx7l17bkjgnr6-git-2.2.1/bin:/gnu/store/paknwghpb3530zpw6kjzygcwyi4v2b7a-tar-1.28/bin:/gnu/store/gzfwcp3rx6vx9yhfn258pqravsihkhgk-gzip-1.6/bin:/gnu/store/v47nyd4lmk6079lahhn7qjg1x30sq6r0-bzip2-1.0.6/bin:/gnu/store/45cspsg2pi0d9n1x62r85iaf6118scnr-xz-5.0.4/bin:/gnu/store/b1hflfspi7d8y8d6xxsm1hpmh1s6aki9-file-5.22/bin:/gnu/store/5x6ypvynrc4y3dnynqj948c6xdhpagv8-diffutils-3.3/bin:/gnu/store/q1fk0vrzdz7vzawq32k2slpgxhrlq0b3-patch-2.7.1/bin:/gnu/store/b1msmz538khma08mg8dm6lw0vkjilbjd-sed-4.2.2/bin:/gnu/store/izbkwxcgikxlinj78lh1934f39n98mn2-findutils-4.4.2/bin:/gnu/store/jyib7byzyincn3q7mkkrm9q5wfbg105z-gawk-4.1.1/bin:/gnu/store/s7jlv9f6v23h17bnkbvcvqk1qnhg40pb-grep-2.21/bin:/gnu/store/vgjlzkg84jpzvz227ac5aygqx25bb6wh-coreutils-8.23/bin:/gnu/store/dvlp6nk7avz403585k9xndl6zqy6vwmj-make-4.1/bin:/gnu/store/nx4zd42igyb7ghmv4mxv6ncg8wr7ypa1-bash-4.3.33/bin:/gnu/store/4x401cpj6nmddji54l99cl89ggn5pgib-ld-wrapper-0/bin:/gnu/store/h7lqkyf4sc37lkbmnph9kmmsfqr3xk5n-binutils-2.25/bin:/gnu/store/16j0v2km34g471cs77gxlq0n0a956cw1-gcc-4.8.4/bin:/gnu/store/q2mm1wv4a3g0b29yv0rjybfjh8kr07qi-glibc-2.20/bin:/gnu/store/q2mm1wv4a3g0b29yv0rjybfjh8kr07qi-glibc-2.20/sbin'
    environment variable `PATH' unset

I think this can be remedied with a bit more work.

-- 
David Thompson
Web Developer - Free Software Foundation - http://fsf.org
GPG Key: 0FF1D807
Support the FSF: https://fsf.org/donate

Re: [PATCH 0/2] Improve search path handling?

[Ludovic Courtès]

David Thompson <dthompson2@worcester.edu> skribis:

> Found one big issue with adding a $PATH search path specification to a
> package: It messes up the 'set-paths' phase of 'gnu-build-system'.
> $PATH ends up being unset!
>
>     environment variable `PATH' set to `/gnu/store/dwjlh4id7ksdjiigfddw5dq617bajxxm-ruby-2.2.0/bin:/gnu/store/cdgpj8djhvfwsysa0bklx7l17bkjgnr6-git-2.2.1/bin:/gnu/store/paknwghpb3530zpw6kjzygcwyi4v2b7a-tar-1.28/bin:/gnu/store/gzfwcp3rx6vx9yhfn258pqravsihkhgk-gzip-1.6/bin:/gnu/store/v47nyd4lmk6079lahhn7qjg1x30sq6r0-bzip2-1.0.6/bin:/gnu/store/45cspsg2pi0d9n1x62r85iaf6118scnr-xz-5.0.4/bin:/gnu/store/b1hflfspi7d8y8d6xxsm1hpmh1s6aki9-file-5.22/bin:/gnu/store/5x6ypvynrc4y3dnynqj948c6xdhpagv8-diffutils-3.3/bin:/gnu/store/q1fk0vrzdz7vzawq32k2slpgxhrlq0b3-patch-2.7.1/bin:/gnu/store/b1msmz538khma08mg8dm6lw0vkjilbjd-sed-4.2.2/bin:/gnu/store/izbkwxcgikxlinj78lh1934f39n98mn2-findutils-4.4.2/bin:/gnu/store/jyib7byzyincn3q7mkkrm9q5wfbg105z-gawk-4.1.1/bin:/gnu/store/s7jlv9f6v23h17bnkbvcvqk1qnhg40pb-grep-2.21/bin:/gnu/store/vgjlzkg84jpzvz227ac5aygqx25bb6wh-coreutils-8.23/bin:/gnu/store/dvlp6nk7avz403585k9xndl6zqy6vwmj-make-4.1/bin:/gnu/store/nx4zd42igyb7ghmv4mxv6ncg8wr7ypa1-bash-4.3.33/bin:/gnu/store/4x401cpj6nmddji54l99cl89ggn5pgib-ld-wrapper-0/bin:/gnu/store/h7lqkyf4sc37lkbmnph9kmmsfqr3xk5n-binutils-2.25/bin:/gnu/store/16j0v2km34g471cs77gxlq0n0a956cw1-gcc-4.8.4/bin:/gnu/store/q2mm1wv4a3g0b29yv0rjybfjh8kr07qi-glibc-2.20/bin:/gnu/store/q2mm1wv4a3g0b29yv0rjybfjh8kr07qi-glibc-2.20/sbin'
>     environment variable `PATH' unset
>
> I think this can be remedied with a bit more work.

I think that’s because build systems are still passed a non-merged
list, no?

Thanks,
Ludo’.

Re: [PATCH 0/2] Improve search path handling?

[David Thompson]

Ludovic Courtès <ludo@gnu.org> writes:

> David Thompson <dthompson2@worcester.edu> skribis:
>
>> Found one big issue with adding a $PATH search path specification to a
>> package: It messes up the 'set-paths' phase of 'gnu-build-system'.
>> $PATH ends up being unset!
>>
>>     environment variable `PATH' set to `/gnu/store/dwjlh4id7ksdjiigfddw5dq617bajxxm-ruby-2.2.0/bin:/gnu/store/cdgpj8djhvfwsysa0bklx7l17bkjgnr6-git-2.2.1/bin:/gnu/store/paknwghpb3530zpw6kjzygcwyi4v2b7a-tar-1.28/bin:/gnu/store/gzfwcp3rx6vx9yhfn258pqravsihkhgk-gzip-1.6/bin:/gnu/store/v47nyd4lmk6079lahhn7qjg1x30sq6r0-bzip2-1.0.6/bin:/gnu/store/45cspsg2pi0d9n1x62r85iaf6118scnr-xz-5.0.4/bin:/gnu/store/b1hflfspi7d8y8d6xxsm1hpmh1s6aki9-file-5.22/bin:/gnu/store/5x6ypvynrc4y3dnynqj948c6xdhpagv8-diffutils-3.3/bin:/gnu/store/q1fk0vrzdz7vzawq32k2slpgxhrlq0b3-patch-2.7.1/bin:/gnu/store/b1msmz538khma08mg8dm6lw0vkjilbjd-sed-4.2.2/bin:/gnu/store/izbkwxcgikxlinj78lh1934f39n98mn2-findutils-4.4.2/bin:/gnu/store/jyib7byzyincn3q7mkkrm9q5wfbg105z-gawk-4.1.1/bin:/gnu/store/s7jlv9f6v23h17bnkbvcvqk1qnhg40pb-grep-2.21/bin:/gnu/store/vgjlzkg84jpzvz227ac5aygqx25bb6wh-coreutils-8.23/bin:/gnu/store/dvlp6nk7avz403585k9xndl6zqy6vwmj-make-4.1/bin:/gnu/store/nx4zd42igyb7ghmv4mxv6ncg8wr7ypa1-bash-4.3.33/bin:/gnu/store/4x401cpj6nmddji54l99cl89ggn5pgib-ld-wrapper-0/bin:/gnu/store/h7lqkyf4sc37lkbmnph9kmmsfqr3xk5n-binutils-2.25/bin:/gnu/store/16j0v2km34g471cs77gxlq0n0a956cw1-gcc-4.8.4/bin:/gnu/store/q2mm1wv4a3g0b29yv0rjybfjh8kr07qi-glibc-2.20/bin:/gnu/store/q2mm1wv4a3g0b29yv0rjybfjh8kr07qi-glibc-2.20/sbin'
>>     environment variable `PATH' unset
>>
>> I think this can be remedied with a bit more work.
>
> I think that’s because build systems are still passed a non-merged
> list, no?

Yes, I think so.  I think I have resolved this, but it's a "rebuild the
world" change so I don't yet know if it works.  Would it be possible to
add a 'wip-search-paths' branch for Hydra to build?  I'm giving it a
shot on my laptop, but if my code fails I won't be very motivated to
toture my computer with another full rebuild.

Also, since I posted the original patch set, I have refactored the code
a bit, resulting in this new procedure in (gnu packages):

    (define* (packages->search-path-specifications packages #:key (native? #t))
      "Deduplicate and merge search path specifications in PACKAGES, a list of
    package objects.  When NATIVE? is '#t', return native search path
    specifications, or standard search path specifications otherwise."
      (merge-search-path-specifications
       (append %base-search-path-specifications
               (delete-duplicates
                (append-map (if native?
                                package-native-search-paths
                                package-search-paths)
                            packages)))))

It factorizes the pattern used in the 'guix package' and 'guix
environment' commands, as well as the 'bag->derivation' and
'bag->cross-derivation' procedures.

-- 
David Thompson
Web Developer - Free Software Foundation - http://fsf.org
GPG Key: 0FF1D807
Support the FSF: https://fsf.org/donate

Re: [PATCH 0/2] Improve search path handling?

[Andreas Enge]

On Sat, Feb 28, 2015 at 12:31:59PM -0500, David Thompson wrote:
> Yes, I think so.  I think I have resolved this, but it's a "rebuild the
> world" change so I don't yet know if it works.  Would it be possible to
> add a 'wip-search-paths' branch for Hydra to build?

Definitely! If you create and push such a branch, we can make it build on
hydra. But maybe now is the moment to push lots of stuff to core-updates
anyway (except that there have been so many changes recently, that I worry
if anything breaks, it will be difficult to determine why).

Andreas

Re: [PATCH 0/2] Improve search path handling?

[Mark H Weaver]

Andreas Enge <andreas@enge.fr> writes:

> On Sat, Feb 28, 2015 at 12:31:59PM -0500, David Thompson wrote:
>> Yes, I think so.  I think I have resolved this, but it's a "rebuild the
>> world" change so I don't yet know if it works.  Would it be possible to
>> add a 'wip-search-paths' branch for Hydra to build?
>
> Definitely! If you create and push such a branch, we can make it build on
> hydra. But maybe now is the moment to push lots of stuff to core-updates
> anyway (except that there have been so many changes recently, that I worry
> if anything breaks, it will be difficult to determine why).

I think we should just push this to 'core-updates' ASAP.

      Mark

Re: [PATCH 0/2] Improve search path handling?

[Ludovic Courtès]

Mark H Weaver <mhw@netris.org> skribis:

> Andreas Enge <andreas@enge.fr> writes:
>
>> On Sat, Feb 28, 2015 at 12:31:59PM -0500, David Thompson wrote:
>>> Yes, I think so.  I think I have resolved this, but it's a "rebuild the
>>> world" change so I don't yet know if it works.  Would it be possible to
>>> add a 'wip-search-paths' branch for Hydra to build?
>>
>> Definitely! If you create and push such a branch, we can make it build on
>> hydra. But maybe now is the moment to push lots of stuff to core-updates
>> anyway (except that there have been so many changes recently, that I worry
>> if anything breaks, it will be difficult to determine why).
>
> I think we should just push this to 'core-updates' ASAP.

I was about to enable whole-system builds for ‘core-updates’.

David, do you want to try anyway or can you wait for the next round
(which I’ll expect will be soon, because there’s another bunch of core
changes I’d like to make)?

Thanks,
Ludo’.

Re: [PATCH 0/2] Improve search path handling?

[Dave Thompson]

Ludovic Courtès <ludo@gnu.org> writes:

> Mark H Weaver <mhw@netris.org> skribis:
>
>> Andreas Enge <andreas@enge.fr> writes:
>>
>>> On Sat, Feb 28, 2015 at 12:31:59PM -0500, David Thompson wrote:
>>>> Yes, I think so.  I think I have resolved this, but it's a "rebuild the
>>>> world" change so I don't yet know if it works.  Would it be possible to
>>>> add a 'wip-search-paths' branch for Hydra to build?
>>>
>>> Definitely! If you create and push such a branch, we can make it build on
>>> hydra. But maybe now is the moment to push lots of stuff to core-updates
>>> anyway (except that there have been so many changes recently, that I worry
>>> if anything breaks, it will be difficult to determine why).
>>
>> I think we should just push this to 'core-updates' ASAP.
>
> I was about to enable whole-system builds for ‘core-updates’.
>
> David, do you want to try anyway or can you wait for the next round
> (which I’ll expect will be soon, because there’s another bunch of core
> changes I’d like to make)?

I think we should wait for the next round.  The patch that causes a
rebuild hasn't been posted here yet, and when I tried to rebuild
everything on my laptop something failed.

Do you think it would be worth it to push these 2 patches now and do the
refactoring/rebuild stuff later?  If so, I think these can just go to
master, because the build system isn't touched.

-- 
David Thompson
Web Developer - Free Software Foundation - http://fsf.org
GPG Key: 0FF1D807
Support the FSF: https://fsf.org/donate

Re: [PATCH 0/2] Improve search path handling?

[Ludovic Courtès]

Dave Thompson <davet@fsf.org> skribis:

> Ludovic Courtès <ludo@gnu.org> writes:
>
>> Mark H Weaver <mhw@netris.org> skribis:
>>
>>> Andreas Enge <andreas@enge.fr> writes:
>>>
>>>> On Sat, Feb 28, 2015 at 12:31:59PM -0500, David Thompson wrote:
>>>>> Yes, I think so.  I think I have resolved this, but it's a "rebuild the
>>>>> world" change so I don't yet know if it works.  Would it be possible to
>>>>> add a 'wip-search-paths' branch for Hydra to build?
>>>>
>>>> Definitely! If you create and push such a branch, we can make it build on
>>>> hydra. But maybe now is the moment to push lots of stuff to core-updates
>>>> anyway (except that there have been so many changes recently, that I worry
>>>> if anything breaks, it will be difficult to determine why).
>>>
>>> I think we should just push this to 'core-updates' ASAP.
>>
>> I was about to enable whole-system builds for ‘core-updates’.
>>
>> David, do you want to try anyway or can you wait for the next round
>> (which I’ll expect will be soon, because there’s another bunch of core
>> changes I’d like to make)?
>
> I think we should wait for the next round.  The patch that causes a
> rebuild hasn't been posted here yet, and when I tried to rebuild
> everything on my laptop something failed.
>
> Do you think it would be worth it to push these 2 patches now and do the
> refactoring/rebuild stuff later?  If so, I think these can just go to
> master, because the build system isn't touched.

I’ve just set up Hydra to build core-updates, so let’s indeed wait for
the next round, it’s safer.

Thanks,
Ludo’.