From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH] Add preseq. Date: Wed, 01 Jul 2015 17:00:17 +0200 Message-ID: <87egkrq5xa.fsf@gnu.org> References: <87r3osronp.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:54185) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZAJUz-00062E-Oz for guix-devel@gnu.org; Wed, 01 Jul 2015 11:00:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZAJUt-0007IQ-Hn for guix-devel@gnu.org; Wed, 01 Jul 2015 11:00:29 -0400 In-Reply-To: (Ricardo Wurmus's message of "Wed, 1 Jul 2015 15:33:11 +0200") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Ricardo Wurmus Cc: guix-devel Ricardo Wurmus skribis: > Ludovic Court=C3=A8s writes: > >>> + (snippet >>> + ;; Remove bundled samtools. Leave the headers. >>> + '(for-each delete-file >>> + (find-files "preseq-master/samtools" >>> + "\\.c$"))))) >> >> Why leave the headers? Isn=E2=80=99t it risky to leave headers that may= be >> different from the Samtools that we=E2=80=99re actually linking against? > > The problem is with our Samtools package(s). They don't install > headers. I'd better update them to install the headers; then I could > just delete the complete "samtools" directory. Yes that would be best, if that=E2=80=99s fine with you. Ludo=E2=80=99.