From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Kost Subject: Re: [PATCH] python2-ansible, python-ccm and dependencies Date: Sun, 26 Jul 2015 12:56:15 +0300 Message-ID: <87egjv2qf4.fsf@gmail.com> References: <87bnf0y2hf.fsf@elephly.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:59915) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZJIfK-000306-C7 for guix-devel@gnu.org; Sun, 26 Jul 2015 05:56:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZJIfH-0003lJ-4x for guix-devel@gnu.org; Sun, 26 Jul 2015 05:56:18 -0400 Received: from mail-la0-x235.google.com ([2a00:1450:4010:c03::235]:36364) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZJIfG-0003kh-Sz for guix-devel@gnu.org; Sun, 26 Jul 2015 05:56:15 -0400 Received: by lagw2 with SMTP id w2so33973621lag.3 for ; Sun, 26 Jul 2015 02:56:13 -0700 (PDT) In-Reply-To: (Eric Dvorsak's message of "Sat, 25 Jul 2015 21:58:15 +0200") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Eric Dvorsak Cc: guix-devel@gnu.org Eric Dvorsak (2015-07-25 22:58 +0300) wrote: > Thank you Ricardo and Alex for taking the time to review and comment my > patch. I edited it to take your advices into account. I hope I did not mi= ss > anything this time Please add the following line to "python.scm": ;;; Copyright =C2=A9 2015 Eric Dvorsak I think you can do it in the first patch. [...] > + (synopsis "Cassandra Cluster Manager") > + (description "A script/library to create, launch and remove an Apach= e Cassandra cluster on localhost.") Please, do not use long lines (more than 72-78 chars). If you use Emacs, you may just "M-q" inside descriptions. [...] > +(define-public python2-ansible > + (package > + (name "python2-ansible") > + (version "1.9.2") > + (source > + (origin > + (method url-fetch) > + (uri (string-append > + "https://pypi.python.org/packages/source/a/ansible/ansible-" > + version > + ".tar.gz")) > + (sha256 > + (base32 > + "007fzgsqaahb0y4gjdxxmir9kcni7wph2z14jhqgpz88idrz8pn2")))) > + (build-system python-build-system) > + (native-inputs > + `(("python2-setuptools" ,python2-setuptools) > + ("python2-pycrypto" ,python2-pycrypto) > + ("python2-httplib2" ,python2-httplib2) > + ("python2-passlib" ,python2-passlib) > + ("python2-nose" ,python2-nose) > + ("python2-mock" ,python2-mock) > + ("python2-jinja2" ,python2-jinja2) > + ("python2-pyyaml" ,python2-pyyaml) > + ("python2-paramiko" ,python2-paramiko))) > + (inputs > + `(("python2-pycrypto" ,python2-pycrypto) > + ("python2-jinja2" ,python2-jinja2) > + ("python2-pyyaml" ,python2-pyyaml) > + ("python2-paramiko" ,python2-paramiko))) > + (arguments > + `(#:python ,python-2)) ; incompatible with Python 3 > + (home-page "http://ansible.com/") > + (synopsis "Radically simple IT automation") > + (description "Ansible is a radically simple IT automation system. I= t handles configuration-management, application deployment, cloud provision= ing, ad-hoc task-execution, and multinode orchestration - including trivial= izing things like zero downtime rolling updates with load balancers.") > + (license gpl3))) I think it should be 'gpl3+'. AFAICS is a usual GPL license which has "or any later version" in it, so we use 'gpl3+' for this. Otherwise, the patches look good to me, perhaps the others will notice more. I can only confirm that the packages built successfully here. --=20 Alex