unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
* [PATCH 2/2] gnu: git-modes: Update to 1.2.0.
@ 2015-08-19 20:21 Alex Kost
  2015-08-22  2:37 ` Mark H Weaver
  0 siblings, 1 reply; 3+ messages in thread
From: Alex Kost @ 2015-08-19 20:21 UTC (permalink / raw)
  To: guix-devel

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: 0002-gnu-git-modes-Update-to-1.2.0.patch --]
[-- Type: text/x-patch, Size: 1781 bytes --]

From b2f3b8873f7243c13cbfdd8395c8adc9a5678418 Mon Sep 17 00:00:00 2001
From: Alex Kost <alezost@gmail.com>
Date: Wed, 19 Aug 2015 23:06:12 +0300
Subject: [PATCH 2/2] gnu: git-modes: Update to 1.2.0.

* gnu/packages/emacs.scm (git-modes): Update to 1.2.0.
  [arguments]: Disable tests.
---
 gnu/packages/emacs.scm | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 5c18154..10634c2 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -265,7 +265,7 @@ when typing parentheses directly or commenting out code line by line.")
 (define-public git-modes
   (package
     (name "git-modes")
-    (version "1.0.0")
+    (version "1.2.0")
     (source (origin
               (method url-fetch)
               (uri (string-append
@@ -274,7 +274,7 @@ when typing parentheses directly or commenting out code line by line.")
               (file-name (string-append name "-" version ".tar.gz"))
               (sha256
                (base32
-                "1biiss75bswx4alk85k3g9p0a3q3sc9i74h4mnrxc2rsk2iwhws0"))))
+                "09dv7ikbj2bi4y3lmvjfzqpdmx2f9bd4w7jkp10bkap62d05iqhk"))))
     (build-system gnu-build-system)
     (arguments
      `(#:modules ((guix build gnu-build-system)
@@ -290,7 +290,7 @@ when typing parentheses directly or commenting out code line by line.")
                           (string-append "LISPDIR="
                                          (assoc-ref %outputs "out")
                                          "/share/emacs/site-lisp"))
-       #:test-target "test"
+       #:tests? #f  ; no check target
        #:phases (modify-phases %standard-phases
                   (delete 'configure)
                   (add-after 'install 'emacs-autoloads
-- 
2.4.3

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 2/2] gnu: git-modes: Update to 1.2.0.
  2015-08-19 20:21 [PATCH 2/2] gnu: git-modes: Update to 1.2.0 Alex Kost
@ 2015-08-22  2:37 ` Mark H Weaver
  2015-08-22 15:39   ` Alex Kost
  0 siblings, 1 reply; 3+ messages in thread
From: Mark H Weaver @ 2015-08-22  2:37 UTC (permalink / raw)
  To: Alex Kost; +Cc: guix-devel

Alex Kost <alezost@gmail.com> writes:

> From b2f3b8873f7243c13cbfdd8395c8adc9a5678418 Mon Sep 17 00:00:00 2001
> From: Alex Kost <alezost@gmail.com>
> Date: Wed, 19 Aug 2015 23:06:12 +0300
> Subject: [PATCH 2/2] gnu: git-modes: Update to 1.2.0.

[...]

> -       #:test-target "test"
> +       #:tests? #f  ; no check target

Interesting.  Did version 1.0.0 have a test suite, and they got rid of
it in 1.2.0?

Otherwise looks good to me.

     Thanks,
       Mark

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 2/2] gnu: git-modes: Update to 1.2.0.
  2015-08-22  2:37 ` Mark H Weaver
@ 2015-08-22 15:39   ` Alex Kost
  0 siblings, 0 replies; 3+ messages in thread
From: Alex Kost @ 2015-08-22 15:39 UTC (permalink / raw)
  To: Mark H Weaver; +Cc: guix-devel

Mark H Weaver (2015-08-22 05:37 +0300) wrote:

> Alex Kost <alezost@gmail.com> writes:
>
>> From b2f3b8873f7243c13cbfdd8395c8adc9a5678418 Mon Sep 17 00:00:00 2001
>> From: Alex Kost <alezost@gmail.com>
>> Date: Wed, 19 Aug 2015 23:06:12 +0300
>> Subject: [PATCH 2/2] gnu: git-modes: Update to 1.2.0.
>
> [...]
>
>> -       #:test-target "test"
>> +       #:tests? #f  ; no check target
>
> Interesting.  Did version 1.0.0 have a test suite, and they got rid of
> it in 1.2.0?

I don't know if 1.0.0 had a test suite, but 1.2.0 definitely does not
have it (neither "check", nor "test" target).

> Otherwise looks good to me.

Thank you.

-- 
Alex

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-08-22 15:39 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-19 20:21 [PATCH 2/2] gnu: git-modes: Update to 1.2.0 Alex Kost
2015-08-22  2:37 ` Mark H Weaver
2015-08-22 15:39   ` Alex Kost

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).