From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Subject: Re: [PATCH 05/19] gnu: Add r-evaluate.
Date: Mon, 14 Sep 2015 12:57:25 +0200
Message-ID: <87egi18e0a.fsf@mdc-berlin.de>
References: <CAMfbzvDonnZoi2P-5LTyEp=_pAsmP-_4oM3TZLPF9zMy_CH45A@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53886)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Ricardo.Wurmus@mdc-berlin.de>) id 1ZbRS2-0005Kn-Mr
	for guix-devel@gnu.org; Mon, 14 Sep 2015 06:57:35 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Ricardo.Wurmus@mdc-berlin.de>) id 1ZbRS1-0004W1-Os
	for guix-devel@gnu.org; Mon, 14 Sep 2015 06:57:34 -0400
Received: from sinope.bbbm.mdc-berlin.de ([141.80.25.23]:59665)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Ricardo.Wurmus@mdc-berlin.de>) id 1ZbRS1-0004Vx-IW
	for guix-devel@gnu.org; Mon, 14 Sep 2015 06:57:33 -0400
In-Reply-To: <CAMfbzvDonnZoi2P-5LTyEp=_pAsmP-_4oM3TZLPF9zMy_CH45A@mail.gmail.com>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Vicente Vera <vicentemvp@gmail.com>
Cc: guix-devel@gnu.org


> * gnu/packages/statistics.scm (r-evaluate): New variable.

[...]

> +    (synopsis "Parsing and Evaluation Tools that Provide More Details
> than the Default")

This synopsis is a bit long (and again: please use lower case).  How
about

  =E2=80=9CParsing and evaluation tools for R=E2=80=9D?

> +    (description
> +     "Parsing and evaluation tools that make it easy to recreate the
> +command line behaviour of R.")

This description is a little short.  What about using the description
derived from the README in the repository:

  =E2=80=9CEvaluate provides tools that allow you to recreate the parsing=
,
  evaluation and display of R code, with enough information that you can
  accurately recreate what happens at the command line.  The tools can
  easily be adapted for other output formats, such as HTML or LaTeX.=E2=80=
=9D

> +    (license license:gpl3+)))

According to LICENSE on Github[1] this package is release under the
=E2=80=9CMIT=E2=80=9D license (=3D Expat?) since version 0.7.3 (you packa=
ged 0.7.2).  This
should be noted when you prepare a new patch and decide to upgrade to
the latest version.

~~ Ricardo