From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] Add MAFFT.
Date: Wed, 16 Sep 2015 22:19:10 +0200
Message-ID: <87eghyazi9.fsf@gnu.org>
References: <55B0E173.1030406@uq.edu.au> <876158xcoo.fsf@mdc-berlin.de>
	<55B44F96.8050808@uq.edu.au> <20150726094338.GA24898@debian>
	<20150726102915.GA32496@debian> <55BBF9E6.50403@uq.edu.au>
	<87d1ybhypp.fsf@gnu.org> <20150907085519.GA4513@debian>
	<55F4187B.8020804@uq.edu.au>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59380)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1ZcJAl-0000aH-NB
	for guix-devel@gnu.org; Wed, 16 Sep 2015 16:19:20 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1ZcJAi-0000tf-KC
	for guix-devel@gnu.org; Wed, 16 Sep 2015 16:19:19 -0400
In-Reply-To: <55F4187B.8020804@uq.edu.au> (Ben Woodcroft's message of "Sat, 12
	Sep 2015 22:20:11 +1000")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ben Woodcroft <b.woodcroft@uq.edu.au>
Cc: "guix-devel@gnu.org" <guix-devel@gnu.org>

Ben Woodcroft <b.woodcroft@uq.edu.au> skribis:

> From 0796e8be05977e6d30eab787a1550bd8d1f12b2d Mon Sep 17 00:00:00 2001
> From: Ben Woodcroft <donttrustben@gmail.com>
> Date: Sat, 12 Sep 2015 22:10:20 +1000
> Subject: [PATCH] gnu: Add mafft.
>
> * gnu/packages/bioinformatics.scm (mafft): New variable.

I=E2=80=99ll leave it to Ricardo, but two minor comments:

> +              (substitute* "Makefile"
> +                ;; remove mafft-homologs.rb from SCRIPTS
> +                (("^SCRIPTS =3D mafft mafft-homologs.rb")
> +                  "SCRIPTS =3D mafft")
> +                ;; remove mafft-distance from PROGS
> +                (("^PROGS =3D dvtditr dndfast7 dndblast sextet5 mafft-di=
stance")
> +                  "PROGS =3D dvtditr dndfast7 dndblast sextet5")
> +                ;; remove mafft-profile from PROGS
> +                (((string-append "splittbfast disttbfast tbfast mafft-pr=
ofile"
> +                                 " f2cl mccaskillwrap"))
> +                 "splittbfast disttbfast tbfast f2cl mccaskillwrap")
> +                (("^rm -f mafft-profile mafft-profile.exe") "#")
> +                (("^rm -f mafft-distance mafft-distance.exe") ")#")
> +                ;; do not install MAN pages in libexec folder
> +                (((string-append "^\t\\$\\(INSTALL\\) -m 644 \\$\\(MANPA=
GES"
> +                                 "\\) \\$\\(DESTDIR\\)\\$\\(LIBDIR\\)"))
> +                 "#"))

Maybe not a blocker, but I would really prefer to patterns to be literal
strings.  If they are too long, we can always split the literal over two
lines:

    "like \
this"

> +   (license (license:non-copyleft "file://license"
> +                                  "See license in the distribution."))))

I think this should be something like:

  (license (license:non-copyleft
             "http://mafft.cbrc.jp/alignment/software/license.txt"
             "BSD-3 with different formatting"))

Thanks,
Ludo=E2=80=99.