From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Kost Subject: Re: [PATCH 2/4] emacs: Add 'guix-devel-download-package-source'. Date: Sun, 04 Oct 2015 21:28:55 +0300 Message-ID: <87eghalc7s.fsf@gmail.com> References: <1443791046-1015-1-git-send-email-alezost@gmail.com> <1443791046-1015-3-git-send-email-alezost@gmail.com> <87d1wvadw2.fsf@gnu.org> <87bnceah2e.fsf@gmail.com> <87r3la6077.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:56134) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zio1t-0004ak-67 for guix-devel@gnu.org; Sun, 04 Oct 2015 14:29:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zio1q-0004FP-0e for guix-devel@gnu.org; Sun, 04 Oct 2015 14:29:01 -0400 In-Reply-To: <87r3la6077.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Sun, 04 Oct 2015 18:57:32 +0200") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Ludovic =?utf-8?Q?Court=C3=A8s?= Cc: guix-devel@gnu.org Ludovic Court=C3=A8s (2015-10-04 19:57 +0300) wrote: > Alex Kost skribis: > >> Ludovic Court=C3=A8s (2015-10-03 23:35 +0300) wrote: >> >>> Alex Kost skribis: >>> >>>> * emacs/guix-devel.el (guix-devel-setup-repl): Use (guix packages) mod= ule. >>>> (guix-devel-download-package-source): New command. >>>> (guix-devel-keys-map): Add key binding for it. >>>> * doc/emacs.texi (Emacs Development): Document it. >>> >>> [...] >>> >>>> +(defun guix-devel-download-package-source () >>>> + "Download the source of the current package. >>>> +Use this function to compute SHA256 hash of the package source." >>>> + (interactive) >>>> + (guix-devel-with-definition def >>>> + (guix-devel-use-modules "(guix scripts download)") >>>> + (when (or (not guix-operation-confirm) >>>> + (y-or-n-p (format "Download '%s' package source?" def))) >>>> + (guix-geiser-eval-in-repl >>>> + (format "(guix-download (origin-uri (package-source %s)))" >>>> + def))))) >>> >>> What about instead building the =E2=80=98package-source-derivation=E2= =80=99 of the >>> package? That way, that would do the exact same thing as =E2=80=98guix= build >>> -S=E2=80=99 and would work not only with =E2=80=98url-fetch=E2=80=99 bu= t also with the other >>> things. >>> >>> WDYT? >> >> The goal of this command is to display a hash. > > So this would be something one would use as they write a package > definition, to fill in the =E2=80=98sha256=E2=80=99 field, right? Exactly. For example, here is how I update a package using Geiser: - I modify its 'version' field, - "C-M-x" to reevaluate the package definition, - "C-c . s" to download the new source and show its hash, - replace the old hash with the new one, - and finally "C-c . b" to build the new version of package. > In that case, I would suggest something based on the URL at point rather > than the origin at point. It's neither URL at point, nor origin at point: it's like "C-c . b" but to download the source of the current package definition instead of building it. Also I don't understand how it can be based on the URL at point as instead of the full URL, we have something like this: (uri (string-append "http://.../foo-" version ".tar.xz")) So currently to use "guix download", at first you need to manually construct the full URL. I find this inconvenient, that's why I want to have a command to download a source of the current package and to display its hash. > However, if this is =E2=80=9Ctoo convenient=E2=80=9D, I=E2=80=99m afraid = this would give an > incentive to not check OpenPGP signatures when they are available. Sorry, I have no idea what it means :-( >> At first I also thought about building a package source and then to >> calculate the hash of the store file, but this way will lead to the >> wrong hashes for "snippet"-ed origins. Or do I miss anything? > > Well, I think bindings for =E2=80=98package-source-derivation=E2=80=99 wo= uld also be > useful, but IIUC this is not what you had in mind. If you mean to make a command to build the current package source, it can be done, although I don't see how it can be useful. --=20 Alex