From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] Gracefully handle incompatible locale data
Date: Tue, 13 Oct 2015 11:50:39 +0200
Message-ID: <87eggzqeq8.fsf@gnu.org>
References: <876132lbic.fsf@gnu.org> <20150922191804.GA13637@domone>
	<877fnijgin.fsf@gnu.org> <20150922215022.GA27201@domone>
	<8737y4hkrz.fsf@gnu.org> <20150924082755.GA4767@domone>
	<87h9mjeqyy.fsf@gnu.org> <5605BA8D.40907@redhat.com>
	<87h9mh5vgn.fsf@gnu.org> <5609A8E9.7050201@redhat.com>
	<561C5525.40501@archlinux.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <libc-alpha-return-63950-glibc-alpha=m.gmane.org@sourceware.org>
List-Unsubscribe: <mailto:libc-alpha-unsubscribe-glibc-alpha=m.gmane.org@sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
In-Reply-To: <561C5525.40501@archlinux.org> (Allan McRae's message of "Tue, 13
	Oct 2015 10:49:41 +1000")
To: Allan McRae <allan@archlinux.org>
Cc: Carlos O'Donell <carlos@redhat.com>, =?utf-8?B?T25kxZllaiBCw61sa2E=?= <neleai@seznam.cz>, libc-alpha@sourceware.org, guix-devel@gnu.org, Roland McGrath <roland@hack.frob.com>
List-Id: guix-devel.gnu.org

Allan McRae <allan@archlinux.org> skribis:

> On 29/09/15 06:54, Carlos O'Donell wrote:
>> On 09/26/2015 06:24 AM, Ludovic Court=C3=A8s wrote:
>>> Furthermore, the function in question returns EINVAL in other similar
>>> cases=E2=80=93e.g., when libc 2.22 loads LC_COLLATE data from libc 2.21.
>>=20
>> If you change this particular case to EINVAL, what does the user see
>> as a result of this change? Do they get a non-zero exit code from
>> `localedef --list-archive` along with an error written out to stderr?
>>=20
>> This is the kind of change I'm expecting. If we are removing an assertio=
n,
>> we should be replacing it with something meaningful and verifying that
>> meaningful change.
>>=20
>> You need not change any of the other cases you've found that return EINV=
AL,
>> we can update those incrementally, but for this one change you're making
>> we should fix it as best we can.
>>=20
>
> If I am reading this correctly, the change to from an abort to EINVAL
> would be fine if it is accompanied by a change to localedef
> --list-archive.  Is that correct?

My understanding is that no such change is needed, but I=E2=80=99m waiting =
for
confirmation or clarification:

  https://sourceware.org/ml/libc-alpha/2015-09/msg00727.html

> A solution to this would be great given we now run into this assert with
> locale archives built with different glibc builds along the 2.22 release
> branch.

I=E2=80=99m glad you value the practical benefits.  ;-)

Ludo=E2=80=99.