From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] Add python-statsmodels.
Date: Mon, 19 Oct 2015 17:47:16 +0200
Message-ID: <87eggqyi63.fsf@gnu.org>
References: <idj8u72zzyq.fsf@bimsb-sys02.mdc-berlin.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54553)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1ZoCeg-0005S6-NG
	for guix-devel@gnu.org; Mon, 19 Oct 2015 11:47:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1ZoCed-00053l-8O
	for guix-devel@gnu.org; Mon, 19 Oct 2015 11:47:22 -0400
In-Reply-To: <idj8u72zzyq.fsf@bimsb-sys02.mdc-berlin.net> (Ricardo Wurmus's
	message of "Fri, 16 Oct 2015 15:48:29 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Cc: guix-devel <guix-devel@gnu.org>

Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> skribis:

> the attached patch adds python{,2}-statsmodels to statistics.scm.  Note
> that this depends on my previous patch adding patsy to the same module.

Hmm I lost track of patsy in my inbox.  I=E2=80=99ll check afterwards.

> From 33ddc045065722a0bac9b28ad909e838b169d7cb Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
> Date: Tue, 13 Oct 2015 13:28:58 +0200
> Subject: [PATCH 1/2] gnu: Add python-statsmodels.
>
> * gnu/packages/statistics.scm (python-statsmodels, python2-statsmodels):
>   New variables.

LGTM.

> +         (add-after 'unpack 'set-matplotlib-backend-to-agg
> +          (lambda _
> +            ;; Set the matplotlib backend to Agg to avoid problems using=
 the
> +            ;; GTK backend without a display.
> +            (substitute* (find-files "statsmodels/graphics/tests" "\\.py=
")
> +              (("import matplotlib\\.pyplot as plt" line)
> +               (string-append "import matplotlib;matplotlib.use('Agg');"
> +                              line)))

This looks good.  Should we eventually change Matplotlib itself to use
this back-end by default?  What=E2=80=99s at stake exactly?

Thanks!

Ludo=E2=80=99.