From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] GCJ: run libjava tests.
Date: Tue, 27 Oct 2015 13:28:30 +0100
Message-ID: <87egggwl5d.fsf@gnu.org>
References: <idjtwpjxitu.fsf@bimsb-sys02.mdc-berlin.net>
	<20151022123345.GA7846@debian>
	<idjmvvbxbp3.fsf@bimsb-sys02.mdc-berlin.net>
	<idjio5zx859.fsf@bimsb-sys02.mdc-berlin.net> <871tcik4b0.fsf@gnu.org>
	<idj4mhcy3us.fsf@bimsb-sys02.mdc-berlin.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43151)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Zr3Mi-0003lw-NB
	for guix-devel@gnu.org; Tue, 27 Oct 2015 08:28:37 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Zr3Me-0004dW-Mv
	for guix-devel@gnu.org; Tue, 27 Oct 2015 08:28:36 -0400
In-Reply-To: <idj4mhcy3us.fsf@bimsb-sys02.mdc-berlin.net> (Ricardo Wurmus's
	message of "Tue, 27 Oct 2015 11:59:07 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Cc: guix-devel <guix-devel@gnu.org>

Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> skribis:

> Attached is a new patch that pulls the =E2=80=98#:test-target=E2=80=99 li=
ne out of the
> =E2=80=98substitute-keyword-arguments=E2=80=99 expression.  The indentati=
on of many
> lines changes because of this.  =E2=80=98git diff -w=E2=80=99 shows that =
the actual
> change is pretty small.

[...]

> +     `(#:test-target "check-target-libjava"
> +       ,@(substitute-keyword-arguments `(#:modules ((guix build gnu-buil=
d-system)
> +                                                    (guix build utils)
> +                                                    (ice-9 regex)
> +                                                    (srfi srfi-1)
> +                                                    (srfi srfi-26))
> +                                                   ,@(package-arguments =
gcc))

#:test-target could even go after #:modules in the argument to
=E2=80=98substitute-keyword-arguments=E2=80=99, for consistency.

Otherwise LGTM.

Thanks!

Ludo=E2=80=99.