[PATCH] doc: Fix 'geiser-guile-load-path' example.

[PATCH] doc: Fix 'geiser-guile-load-path' example.

[Alex Kost]

[-- Attachment #1: Type: text/plain, Size: 161 bytes --]

(add-to-list 'geiser-guile-load-path 'foo) errors if "geiser-guile.el"
is not loaded yet, so I think it's better to put it inside
'with-eval-after-load', WDYT?


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-doc-Fix-geiser-guile-load-path-example.patch --]
[-- Type: text/x-diff, Size: 954 bytes --]

From a7b4af5d3115d6caa9129cdf8a9933f640742063 Mon Sep 17 00:00:00 2001
From: Alex Kost <alezost@gmail.com>
Date: Sat, 14 Nov 2015 21:13:07 +0300
Subject: [PATCH] doc: Fix 'geiser-guile-load-path' example.

Reported by marusich on #guix.

* doc/contributing.texi (The Perfect Setup): Wrap modifying
  'geiser-guile-load-path' into 'with-eval-after-load'.
---
 doc/contributing.texi | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/doc/contributing.texi b/doc/contributing.texi
index cdc3f6d..55b844a 100644
--- a/doc/contributing.texi
+++ b/doc/contributing.texi
@@ -141,7 +141,8 @@ that it finds source files from your checkout:
 
 @lisp
 ;; @r{Assuming the Guix checkout is in ~/src/guix.}
-(add-to-list 'geiser-guile-load-path "~/src/guix")
+(with-eval-after-load 'geiser-guile
+  (add-to-list 'geiser-guile-load-path "~/src/guix"))
 @end lisp
 
 To actually edit the code, Emacs already has a neat Scheme mode.  But in
-- 
2.6.1

Re: [PATCH] doc: Fix 'geiser-guile-load-path' example.

[Ludovic Courtès]

Alex Kost <alezost@gmail.com> skribis:

> (add-to-list 'geiser-guile-load-path 'foo) errors if "geiser-guile.el"
> is not loaded yet, so I think it's better to put it inside
> 'with-eval-after-load', WDYT?

Sounds good.  I guess that’s because (require 'guix-init) doesn’t
require 'geiser?

Ludo’.

Re: [PATCH] doc: Fix 'geiser-guile-load-path' example.

[Alex Kost]

Ludovic Courtès (2015-11-15 20:41 +0300) wrote:

> Alex Kost <alezost@gmail.com> skribis:
>
>> (add-to-list 'geiser-guile-load-path 'foo) errors if "geiser-guile.el"
>> is not loaded yet, so I think it's better to put it inside
>> 'with-eval-after-load', WDYT?
>
> Sounds good.  I guess that’s because (require 'guix-init) doesn’t
> require 'geiser?

"guix-init.el" shouldn't require geiser.  IMO it should load as less
code as possible, because it will increase the Emacs start time.

In general I think requiring/loading packages is evil (as it slows down
starting Emacs), so I avoid 'require'-s when possible in my init file.

-- 
Alex

Re: [PATCH] doc: Fix 'geiser-guile-load-path' example.

[Ludovic Courtès]

Alex Kost <alezost@gmail.com> skribis:

> Ludovic Courtès (2015-11-15 20:41 +0300) wrote:
>
>> Alex Kost <alezost@gmail.com> skribis:
>>
>>> (add-to-list 'geiser-guile-load-path 'foo) errors if "geiser-guile.el"
>>> is not loaded yet, so I think it's better to put it inside
>>> 'with-eval-after-load', WDYT?
>>
>> Sounds good.  I guess that’s because (require 'guix-init) doesn’t
>> require 'geiser?
>
> "guix-init.el" shouldn't require geiser.  IMO it should load as less
> code as possible, because it will increase the Emacs start time.
>
> In general I think requiring/loading packages is evil (as it slows down
> starting Emacs), so I avoid 'require'-s when possible in my init file.

Agreed, I was just making sure I understood the issue at hand.

The patch you sent looks good to me then.

Thanks!

Ludo’.

Re: [PATCH] doc: Fix 'geiser-guile-load-path' example.

[Alex Kost]

Ludovic Courtès (2015-11-17 19:16 +0300) wrote:

> Alex Kost <alezost@gmail.com> skribis:
>
>> Ludovic Courtès (2015-11-15 20:41 +0300) wrote:
>>
>>> Alex Kost <alezost@gmail.com> skribis:
>>>
>>>> (add-to-list 'geiser-guile-load-path 'foo) errors if "geiser-guile.el"
>>>> is not loaded yet, so I think it's better to put it inside
>>>> 'with-eval-after-load', WDYT?
>>>
>>> Sounds good.  I guess that’s because (require 'guix-init) doesn’t
>>> require 'geiser?
>>
>> "guix-init.el" shouldn't require geiser.  IMO it should load as less
>> code as possible, because it will increase the Emacs start time.
>>
>> In general I think requiring/loading packages is evil (as it slows down
>> starting Emacs), so I avoid 'require'-s when possible in my init file.
>
> Agreed, I was just making sure I understood the issue at hand.

OK.  Actually I thought that you use 'with-eval-after-load' or
'eval-after-load' or 'use-package', and you just didn't mention it in
the manual because it's a common Emacs thing.  But it looks like you use
a straightforward (add-to-list ...), which can work only if
"geiser-guile.el" is already loaded.  Out of curiosity, do you somehow
load the whole geiser in your emacs config?  If so, why?

I mean not just (require 'geiser), as it does not load
"geiser-guile.el", but maybe (require 'geiser-mode) or something like
it.

(I personally don't touch 'geiser-guile-load-path' at all, I just set
GUILE_LOAD_PATH in my ".bash_profile" instead)

> The patch you sent looks good to me then.

Thanks!

-- 
Alex

Re: [PATCH] doc: Fix 'geiser-guile-load-path' example.

[Ludovic Courtès]

Alex Kost <alezost@gmail.com> skribis:

> OK.  Actually I thought that you use 'with-eval-after-load' or
> 'eval-after-load' or 'use-package', and you just didn't mention it in
> the manual because it's a common Emacs thing.  But it looks like you use
> a straightforward (add-to-list ...), which can work only if
> "geiser-guile.el" is already loaded.  Out of curiosity, do you somehow
> load the whole geiser in your emacs config?  If so, why?
>
> I mean not just (require 'geiser), as it does not load
> "geiser-guile.el", but maybe (require 'geiser-mode) or something like
> it.

I have:

  (require 'geiser-install)
  (require 'geiser)

> (I personally don't touch 'geiser-guile-load-path' at all, I just set
> GUILE_LOAD_PATH in my ".bash_profile" instead)

I touch ‘geiser-guile-load-path’ because I want it to point to a bunch
of source trees.

Conversely, I don’t want GUILE_LOAD_PATH to point to source trees, so it
only points to installation directories.

Ludo’.

Re: [PATCH] doc: Fix 'geiser-guile-load-path' example.

[Alex Kost]

Ludovic Courtès (2015-11-18 00:40 +0300) wrote:

> Alex Kost <alezost@gmail.com> skribis:
>
>> OK.  Actually I thought that you use 'with-eval-after-load' or
>> 'eval-after-load' or 'use-package', and you just didn't mention it in
>> the manual because it's a common Emacs thing.  But it looks like you use
>> a straightforward (add-to-list ...), which can work only if
>> "geiser-guile.el" is already loaded.  Out of curiosity, do you somehow
>> load the whole geiser in your emacs config?  If so, why?
>>
>> I mean not just (require 'geiser), as it does not load
>> "geiser-guile.el", but maybe (require 'geiser-mode) or something like
>> it.
>
> I have:
>
>   (require 'geiser-install)
>   (require 'geiser)

You don't need (require 'geiser) as (require 'geiser-install) loads it
anyway (look at "M-x find-library geiser-install").

But after this, 'geiser-guile-load-path' shouldn't be available, as it
is placed in "geiser-guile.el" which is not loaded by "geiser.el".  So
if (featurep 'geiser-guile) gives you `t' right after Emacs start, then
there is something else (I would say “something evil” :-)) in your
config that loads the whole Geiser functionality.

>> (I personally don't touch 'geiser-guile-load-path' at all, I just set
>> GUILE_LOAD_PATH in my ".bash_profile" instead)
>
> I touch ‘geiser-guile-load-path’ because I want it to point to a bunch
> of source trees.
>
> Conversely, I don’t want GUILE_LOAD_PATH to point to source trees, so it
> only points to installation directories.

Ah, I see your point, thanks.

-- 
Alex

Re: [PATCH] doc: Fix 'geiser-guile-load-path' example.

[Ludovic Courtès]

Alex Kost <alezost@gmail.com> skribis:

> Ludovic Courtès (2015-11-18 00:40 +0300) wrote:

[...]

>> I have:
>>
>>   (require 'geiser-install)
>>   (require 'geiser)
>
> You don't need (require 'geiser) as (require 'geiser-install) loads it
> anyway (look at "M-x find-library geiser-install").
>
> But after this, 'geiser-guile-load-path' shouldn't be available, as it
> is placed in "geiser-guile.el" which is not loaded by "geiser.el".  So
> if (featurep 'geiser-guile) gives you `t' right after Emacs start, then
> there is something else (I would say “something evil” :-)) in your
> config that loads the whole Geiser functionality.

Weird, I don’t see anything obvious.  Nevertheless, I’ve changed my
.emacs to use ‘with-eval-after-load’.

Thanks for educating me!  :-)

Ludo’.