From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 6/6] gnu: Add emacs-slime.
Date: Tue, 05 Jan 2016 23:17:59 +0100
Message-ID: <87egdvk6w8.fsf@gnu.org>
References: <CAKrPhPNBb2FoSGNM9cPgQe2i=7RQcKJyx6gzPo+4QW+SFO0KvQ@mail.gmail.com>
	<56847D01.3010702@uq.edu.au>
	<CAKrPhPO5uf55RrzyzdPXTTU3SzbH_-t_R43aXtTfiJro2ex7jQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41653)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1aGZva-0000Iw-1M
	for guix-devel@gnu.org; Tue, 05 Jan 2016 17:18:07 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1aGZvW-0004YP-OH
	for guix-devel@gnu.org; Tue, 05 Jan 2016 17:18:05 -0500
In-Reply-To: <CAKrPhPO5uf55RrzyzdPXTTU3SzbH_-t_R43aXtTfiJro2ex7jQ@mail.gmail.com>
	(Federico Beffa's message of "Thu, 31 Dec 2015 10:12:55 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Federico Beffa <beffa@ieee.org>
Cc: Guix-devel <guix-devel@gnu.org>

Federico Beffa <beffa@ieee.org> skribis:

> From e3dd3f2235b9aed36d213f68ea767225ec8ebd61 Mon Sep 17 00:00:00 2001
> From: Federico Beffa <beffa@fbengineering.ch>
> Date: Wed, 30 Dec 2015 00:47:29 +0100
> Subject: [PATCH 6/6] gnu: Add emacs-slime.
>
> * gnu/packages/emacs.scm (emacs-slime): New variable.

[...]

> +    (inputs
> +     `(("texlive" ,texlive)
> +       ("texinfo" ,texinfo)))

Should be =E2=80=98native-inputs=E2=80=99.

> +         (add-before 'install 'install-doc
> +           (lambda* (#:key outputs #:allow-other-keys)
> +             (let* ((out (assoc-ref outputs "out"))
> +                    (info-dir (string-append out "/share/info"))
> +                    (doc-dir (string-append out "/share/doc/"
> +                                            ,name "-" ,version))
> +                    (doc-files '("doc/slime.pdf" "doc/slime-refcard.pdf"
> +                                 "README.md" "NEWS" "PROBLEMS"
> +                                 "CONTRIBUTING.md")))
> +               (with-directory-excursion "doc"
> +                 (substitute* "Makefile"
> +                   (("infodir=3D/usr/local/info")
> +                    (string-append "infodir=3D" info-dir)))
> +                 (system* "make" "all")
> +                 (install-file "slime.info" info-dir)
> +                 (copy-recursively "html" (string-append doc-dir "/html"=
)))
> +               (for-each (lambda (f)
> +                           (install-file f doc-dir)
> +                           (delete-file f))
> +                         doc-files)
> +               (delete-file-recursively "doc")

Can we build and install only Info files?  This is what we usually do
for packages that have Texinfo manuals.  Incidentally, it allows us to
get rid of the TeX Live dependency.

> +    (synopsis
> +     "Superior Lisp Interaction Mode for Emacs")

Move to previous line.

> +    (description
> +     "SLIME extends Emacs with support for interactive programming in
> +Common Lisp.  The features are centered around slime-mode, an Emacs

@code{slime-mode}

> +minor-mode that complements the standard lisp-mode.  While lisp-mode

s/minor-mode/minor mode/
@code{lisp-mode}

> +supports editing Lisp source files, slime-mode adds support for

@code{slime-mode}

> +interacting with a running Common Lisp process for compilation,
> +debugging, documentation lookup, and so on.")

Could you send an updated patch?

Thanks,
Ludo=E2=80=99.