From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH 01/04] gnu: Add python-pygpgme Date: Sat, 06 Feb 2016 13:55:35 +0100 Message-ID: <87egcq0zi0.fsf@gnu.org> References: <87fux6fqlj.fsf@dustycloud.org> <20160206082958.GC1432@jasmine> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:50715) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aS2Ot-0007Bb-T9 for guix-devel@gnu.org; Sat, 06 Feb 2016 07:55:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aS2Op-00083v-4m for guix-devel@gnu.org; Sat, 06 Feb 2016 07:55:43 -0500 In-Reply-To: <20160206082958.GC1432@jasmine> (Leo Famulari's message of "Sat, 6 Feb 2016 03:29:58 -0500") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Leo Famulari Cc: guix-devel@gnu.org Leo Famulari skribis: > On Fri, Feb 05, 2016 at 07:47:26PM -0800, Christopher Allan Webber wrote: [...] >> + ;; Unfortunately, we have to disable some tests due to some gpg-= agent >> + ;; goofiness... see: >> + ;; https://bugs.launchpad.net/pygpgme/+bug/999949 >> + (patches (list (search-patch "pygpgme-disable-problematic-tests.= patch"))))) >> + (arguments >> + `(#:phases >> + (modify-phases %standard-phases >> + (add-before 'build 'make-build >> + (lambda (. args) >> + (zero? (system* "make" "build")))) > > I'm not a Scheme expert, but I wonder about "lambda (.args)". Most of > these calls to (system*) start with "lambda _". What is the difference > here? (lambda (. args) =E2=80=A6) is equivalent to (lambda args =E2=80=A6), meani= ng a procedure that takes an unlimited number of arguments. It=E2=80=99s a convention to use =E2=80=98_=E2=80=99 to denote unused varia= bles, so we usually write (lambda _ =E2=80=A6) in such cases. The lambda above is slightly two indented; perhaps the guix-devel Emacs mode isn=E2=80=99t loaded? >> + ("gnupg" ,gnupg-2.0) > > Does it only work with gnupg-2.0? We also package the 2.1 series of > GnuPG. I think we should stick to 2.0, which is the latest stable version. >> + ("gpgme" ,gpgme))) >> + (home-page "https://launchpad.net/pygpgme") >> + (synopsis >> + "A Python module for working with OpenPGP messages") > > This can all go on one line. Also please remove =E2=80=9CA=E2=80=9D (I think =E2=80=98guix lint=E2=80=99= would complain.) OK to push with these and Leo=E2=80=99s other comments addressed! Thank you, Ludo=E2=80=99.