From: ludo@gnu.org (Ludovic Courtès)
To: Jan Nieuwenhuizen <janneke@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu-build-system: do not patch symlinks. Fixes location-aware scripts.
Date: Tue, 09 Feb 2016 11:41:56 +0100 [thread overview]
Message-ID: <87egcmkvwr.fsf@gnu.org> (raw)
In-Reply-To: <87egcpeono.fsf@gnu.org> (Jan Nieuwenhuizen's message of "Sat, 06 Feb 2016 18:26:03 +0100")
Jan Nieuwenhuizen <janneke@gnu.org> skribis:
> When patch-shebang encounters a script that is a symlink, say
>
> bin/script -> ../lib/foo/thescript
>
> it will change it into a file with rewritten #! . That breaks whenever
> `thescript' assumes it lives in lib/foo.
Out of curiosity, what package was this?
> From 5a1793944b6ba1368a355edfa5be1b5c542ba48c Mon Sep 17 00:00:00 2001
> From: Jan Nieuwenhuizen <janneke@gnu.org>
> Date: Sat, 6 Feb 2016 15:59:51 +0100
> Subject: [PATCH] gnu-build-system: do not patch symlinks. Fixes
> location-aware scripts.
>
> * guix/build/gnu-build-system.scm (patch-shebangs): avoid patching symlinks.
> Fixes scripts
Since this is a rebuild-the-world change, I applied to to a new
‘core-updates’ branch (and adjusted the commit log.)
Thank you!
Ludo’.
next prev parent reply other threads:[~2016-02-09 10:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-06 17:26 [PATCH] gnu-build-system: do not patch symlinks. Fixes location-aware scripts Jan Nieuwenhuizen
2016-02-09 10:41 ` Ludovic Courtès [this message]
2016-02-09 19:19 ` Jan Nieuwenhuizen
2016-02-09 20:59 ` Ludovic Courtès
2016-02-09 22:15 ` Jan Nieuwenhuizen
2016-02-10 21:30 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87egcmkvwr.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=janneke@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).