From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christopher Allan Webber Subject: Re: [PATCH] gnu: Add python-psycopg2, python2-psycopg2 Date: Sun, 21 Feb 2016 18:38:51 -0800 Message-ID: <87egc54gg4.fsf@dustycloud.org> References: <20160219120106.62631a44@scratchpost.org> <20160219212258.GA4418@jasmine> <20160222013949.186f25bc@scratchpost.org> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:59146) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aXgOp-0008BL-Qf for guix-devel@gnu.org; Sun, 21 Feb 2016 21:39:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aXgOm-0006d3-KN for guix-devel@gnu.org; Sun, 21 Feb 2016 21:38:59 -0500 Received: from dustycloud.org ([50.116.34.160]:49236) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aXgOm-0006cy-GA for guix-devel@gnu.org; Sun, 21 Feb 2016 21:38:56 -0500 In-reply-to: <20160222013949.186f25bc@scratchpost.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Danny Milosavljevic Cc: guix-devel Danny Milosavljevic writes: > Hi, > > On Fri, 19 Feb 2016 16:22:58 -0500 > Leo Famulari wrote: > >> > + `(#:tests? #f)) ; TODO re-enable >> >> Why are the tests disabled? > > Because it would require a postgresql database "psycopg2_test" and a > running postgresql database management service. > > Not sure what the usual way to do that is. Should it create the db on > a temporary dbms service on-the-fly and drop it later? > > Or we could mock out the server and just have it return constant stuff > as if it was postgresql. Is that already available somewhere? My personal suggestion would be to push to master without the tests for now, and add a comment explaining why this is hard. I think someone needs to figure out a nice way to spin up a mini-service for running postgres during tests; some of my stuff could use that too. But we should merge and push this with an additional comment.