From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] guix: use '@' in package-full-name instead of '-'
Date: Thu, 28 Apr 2016 14:07:05 +0200
Message-ID: <87eg9qhr86.fsf@gnu.org>
References: <1461810323-21018-1-git-send-email-tipecaml@gmail.com>
	<87y47yuop7.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41929)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1avkiw-0005Oc-66
	for guix-devel@gnu.org; Thu, 28 Apr 2016 08:07:15 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1avkiv-0007d3-0D
	for guix-devel@gnu.org; Thu, 28 Apr 2016 08:07:14 -0400
In-Reply-To: <87y47yuop7.fsf@gnu.org> (Mathieu Lirzin's message of "Thu, 28
	Apr 2016 10:23:16 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Mathieu Lirzin <mthl@gnu.org>
Cc: guix-devel@gnu.org

Mathieu Lirzin <mthl@gnu.org> skribis:

> Cyril Roelandt <tipecaml@gmail.com> writes:
>
>> * guix/packages.scm (package-full-name): Use '@' instead of '-'.
>> ---
>>  guix/packages.scm | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/guix/packages.scm b/guix/packages.scm
>> index d62d1f3..e33791e 100644
>> --- a/guix/packages.scm
>> +++ b/guix/packages.scm
>> @@ -346,7 +346,7 @@ name of its URI."
>>=20=20
>>  (define (package-full-name package)
>>    "Return the full name of PACKAGE--i.e., `NAME-VERSION'."
>> -  (string-append (package-name package) "-" (package-version package)))
>> +  (string-append (package-name package) "@" (package-version package)))
>>=20=20
>>  (define (%standard-patch-inputs)
>>    (let* ((canonical (module-ref (resolve-interface '(gnu packages base))
>
> Unfortunately, changing this is not as simple.
>
> When implementing the '-' to '@' thing, I have proposed to switch
> =E2=80=98package-full-name=E2=80=99.  While I still think it would make s=
ense for it to
> use '@', it would require a full rebuild of every package + extra care.

No no, no full rebuild, only extra care.  :-)

> For example among other things the tests will not be happy for =E2=80=98g=
uix
> graph=E2=80=98 IIRC, and the Guix website uses it to access Hydra links.

Right, there are a few places that sorta expect a hyphen; the thing that
generates <http://gnu.org/s/guix/packages> is the only one that comes to
mind, though.

When discussing the patch series for the @ syntax, we discussed at one
point making the delimiter of =E2=80=98package-full-name=E2=80=99 an option=
al parameter
that would default to @.  It appears in the patch at:

  https://lists.gnu.org/archive/html/guix-devel/2016-01/msg00873.html

I=E2=80=99m not sure why we dropped it, but we should try to reinstate it.

Cyril, can you make the delimiter an optional argument and see whether
=E2=80=98make check=E2=80=99 passes?

Thanks!

Ludo=E2=80=99.