From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Kost Subject: Re: [PATCH] gnu: Add nlopt. Date: Wed, 04 May 2016 11:38:36 +0300 Message-ID: <87eg9igqur.fsf@gmail.com> References: <87vb3twtgi.fsf@gnu.org> <87egah85e4.fsf@gnu.org> <87a8l5xc9w.fsf@gnu.org> <87wpo6n8y5.fsf@gnu.org> <87futz5rqv.fsf@gnu.org> <87h9efcqid.fsf@gnu.org> <87bn4n5ngw.fsf@gnu.org> <87futylxk6.fsf@gnu.org> <87pot2zyjq.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:54259) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1axsLJ-0002Wz-Ao for guix-devel@gnu.org; Wed, 04 May 2016 04:39:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1axsL7-0006su-J3 for guix-devel@gnu.org; Wed, 04 May 2016 04:39:31 -0400 In-Reply-To: <87pot2zyjq.fsf@gnu.org> (Roel Janssen's message of "Tue, 03 May 2016 22:17:29 +0200") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Roel Janssen Cc: guix-devel@gnu.org Roel Janssen (2016-05-03 23:17 +0300) wrote: > Ludovic Court=C3=A8s writes: > >> Roel Janssen skribis: >> >>> I added your magic for Guile. Here is the patch: >>> >>>>From 6221baadea331cff7e8ab6b9ea1b3bb7737b227f Mon Sep 17 00:00:00 2001 >>> From: Roel Janssen >>> Date: Tue, 3 May 2016 14:30:25 +0200 >>> Subject: [PATCH] gnu: Add nlopt. >>> >>> * gnu/packages/maths.scm (nlopt): New variable. >> >> Pushed with minor cosmetic changes, notably: >> >>> + (source (origin >>> + (method url-fetch) >>> + (uri (string-append "http://ab-initio.mit.edu/nlopt/nlopt-" >>> + version ".tar.gz")) >>> + (sha256 >>> + (base32 "12cfkkhcdf4zmb6h7y6qvvdvqjs2xf9sjpa3rl3bq76px4yn76c0")= ))) >> >> =E2=80=9C(method=E2=80=9D should be indented below the =E2=80=9Cr=E2=80= =9D of =E2=80=9Corigin=E2=80=9D (I think this >> pattern also appears in the R patches you recently submitted.) >> >> Thank you! > > I've been submitting most packages this way. Should I align (method > ...) to the r in origin for all packages in the future? Yes, 'method' is a sub-expression or 'origin', not of 'source', and it should be aligned accordingly. I suppose you don't use Emacs; may I ask what editor do you use? --=20 Alex