Re: [PATCH] gnu: Add nlopt.

[Alex Kost <alezost@gmail.com>]

Roel Janssen (2016-05-03 23:17 +0300) wrote:

> Ludovic Courtès writes:
>
>> Roel Janssen <roel@gnu.org> skribis:
>>
>>> I added your magic for Guile.  Here is the patch:
>>>
>>>From 6221baadea331cff7e8ab6b9ea1b3bb7737b227f Mon Sep 17 00:00:00 2001
>>> From: Roel Janssen <roel@gnu.org>
>>> Date: Tue, 3 May 2016 14:30:25 +0200
>>> Subject: [PATCH] gnu: Add nlopt.
>>>
>>> * gnu/packages/maths.scm (nlopt): New variable.
>>
>> Pushed with minor cosmetic changes, notably:
>>
>>> +    (source (origin
>>> +      (method url-fetch)
>>> +      (uri (string-append "http://ab-initio.mit.edu/nlopt/nlopt-"
>>> +                          version ".tar.gz"))
>>> +      (sha256
>>> +       (base32 "12cfkkhcdf4zmb6h7y6qvvdvqjs2xf9sjpa3rl3bq76px4yn76c0"))))
>>
>> “(method” should be indented below the “r” of “origin” (I think this
>> pattern also appears in the R patches you recently submitted.)
>>
>> Thank you!
>
> I've been submitting most packages this way.  Should I align (method
> ...) to the r in origin for all packages in the future?

Yes, 'method' is a sub-expression or 'origin', not of 'source', and it
should be aligned accordingly.

I suppose you don't use Emacs; may I ask what editor do you use?

-- 
Alex