From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH] gnu: Add sicp. Date: Tue, 17 May 2016 22:55:46 +0200 Message-ID: <87eg90wgj1.fsf@gnu.org> References: <87d1onafmy.fsf@drakenvlieg.flower> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:53341) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b2qR2-00087L-7D for guix-devel@gnu.org; Tue, 17 May 2016 21:38:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b2m2B-0005eS-Fa for guix-devel@gnu.org; Tue, 17 May 2016 16:56:10 -0400 In-Reply-To: <87d1onafmy.fsf@drakenvlieg.flower> (Jan Nieuwenhuizen's message of "Sun, 15 May 2016 10:29:09 +0200") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Jan Nieuwenhuizen Cc: guix-devel@gnu.org Hi! Jan Nieuwenhuizen skribis: > Too lazy to get up and go for my book shelf, I was presently surprised > that SICP is available in info; and even more surprised it hasn't been > packaged yet. Indeed! :-) > From 85c7f3d9ba64989b2fbdba9ee0a0da6c635b1d3c Mon Sep 17 00:00:00 2001 > From: Jan Nieuwenhuizen > Date: Sun, 15 May 2016 09:57:05 +0200 > Subject: [PATCH] gnu: Add sicp. > > * gnu/packages/sicp.scm: New file. > * gnu/local.mk (GNU_SYSTEM_MODULES): Add it. What about putting it in (gnu packages scheme) instead? Sounds like a natural home. > +(define-public sicp > + (package > + (name "sicp") > + (version "2016-02-20") > + (source > + (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/sarabander/sicp") > + (commit "5b52db566968d28a89fbbaf338d207f01cc81cac"))) Could you change the =E2=80=98version=E2=80=99 field according to the conve= ntions described at (info "(guix) Version Numbers")? Since there=E2=80=99s no rel= ease number, it=E2=80=99s OK to use =E2=80=9C20160220=E2=80=9D (no hyphens) befo= re the rest of the version field. > + (sha256 > + (base32 > + "10h6h7szwlfbshwh18bnl2hvyddj5i7106l79s145l0sjjv15cxb")))) > + (build-system trivial-build-system) > + (native-inputs `(("gzip" ,gzip) > + ("source" ,source) > + ("texinfo" ,texinfo))) > + (arguments > + `(#:modules ((guix build utils) > + (srfi srfi-1) > + (srfi srfi-26)) > + #:builder #:builder should be aligned with #:modules. > + (let ((gzip (assoc-ref %build-inputs "gzip")) > + (source (assoc-ref %build-inputs "source")) > + (texinfo (assoc-ref %build-inputs "texinfo")) > + (info-dir (string-append %output "/share/info"))) > + (use-modules (guix build utils) > + (srfi srfi-1) > + (srfi srfi-26)) Please move =E2=80=98use-modules=E2=80=99 to the top: (begin (use-modules (srfi =E2=80=A6) =E2=80=A6) (let (=E2=80=A6) =E2=80=A6)) > + (and > + (system* "makeinfo" > + "--output" (string-append info-dir "/sicp.i= nfo") > + (string-append source "/sicp-pocket.texi")) (zero? (system* =E2=80=A6)) > + (home-page "http://sarabander.github.io/sicp") > + (synopsis "Structure and Interpretation of Computer Programs") > + (description "Structure and Interpretation of Computer Programs (SIC= P) is > +a textbook aiming to teach the principles of computer programming. > + > +Using Scheme, a dialect of the Lisp programming language, the book expla= ins > +core computer science concepts such as abstraction in programming, > +metalinguistic abstraction, recursion, interpreters, and modular program= ming. > + > +It was first published in 1985 by MIT Press and written by Massachusetts > +Institute of Technology (MIT) professors Harold Abelson and Gerald Jay > +Sussman, with Julie Sussman.") I would remove the last paragraph. Could you send an updated patch? Thanks for filling this gap! :-) Ludo=E2=80=99.