Re: [Patch] ruby-debug-inspector

[Matthew Jordan <matthewjordandevops@yandex.com>]

[-- Attachment #1: Type: text/plain, Size: 1041 bytes --]

Good day,

I have updated the patch based on the suggestions made.
Thanks for the feedback.

> Thanks for the patch, all patches toward rails are much appreciated. I 
> do have a few comments though.
>>> * gnu/packages/rails.scm: New file.
> I'm of the opinion that we should keep most ruby packages in 
> gnu/packages/ruby.scm because to me "is this ruby package a rails 
> package?" is not one with a straightforward answer. We already have 
> activesupport in ruby.scm for instance, and that is more of a rails 
> package than this I would argue.

While this is true to some extent, would it really be a good idea to put
all ruby packages in one file?

Also if I absolutely have to move them to ruby.scm, could I do so in
different patch, as I have several patches in that branch that would
need to be rebased (probably manually).

> Can you send an updated patch please? I'll look at your other patches 
> soon too.
I have no problem making changes and updates, I still have much to
learn. And about the other patches much appreciated.


[-- Attachment #2: patch to add ruby-debug-inspector. --]
[-- Type: text/x-patch, Size: 2974 bytes --]

From 5d1ba9e16d5cdd37521f068f0304730e39837e9f Mon Sep 17 00:00:00 2001
From: Matthew Jordan <matthewjordandevops@yandex.com>
Date: Tue, 31 May 2016 07:26:24 -0400
Subject: [PATCH] gnu: Add ruby-debug-inspector.

* gnu/local.mk (GNU_SYSTEM_MODULES): Add it.
* gnu/packages/rails.scm: New file.
---
 gnu/local.mk           |  1 +
 gnu/packages/rails.scm | 50 ++++++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 51 insertions(+)
 create mode 100644 gnu/packages/rails.scm

diff --git a/gnu/local.mk b/gnu/local.mk
index 86b56d4..4c21827 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -285,6 +285,7 @@ GNU_SYSTEM_MODULES =				\
   %D%/packages/qemu.scm				\
   %D%/packages/qt.scm				\
   %D%/packages/ragel.scm			\
+  %D%/packages/rails.scm			\
   %D%/packages/ratpoison.scm			\
   %D%/packages/rc.scm				\
   %D%/packages/rdesktop.scm			\
diff --git a/gnu/packages/rails.scm b/gnu/packages/rails.scm
new file mode 100644
index 0000000..77ab354
--- /dev/null
+++ b/gnu/packages/rails.scm
@@ -0,0 +1,50 @@
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2016 Matthew Jordan <matthewjordandevops@yandex.com>
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
+
+(define-module (gnu packages rails)
+  #:use-module (guix licenses)
+  #:use-module (guix download)
+  #:use-module (guix packages)
+  #:use-module (gnu packages ruby)
+  #:use-module (guix build-system ruby))
+
+(define-public ruby-debug-inspector
+  (package
+    (name "ruby-debug-inspector")
+    (version "0.0.2")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (rubygems-uri "debug_inspector" version))
+       (sha256
+        (base32
+         "109761g00dbrw5q0dfnbqg8blfm699z4jj70l4zrgf9mzn7ii50m"))))
+    (build-system ruby-build-system)
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (replace 'check
+           (lambda _
+             (zero? (system* "ruby" "-Ilib" "-r" "debug_inspector")))))))
+    (synopsis "Ruby wrapper for the MRI 2.0 debug_inspector API")
+    (description
+     "This package provides a Ruby wrapper for the MRI 2.0 debug_inspector
+API.")
+    (home-page
+     "https://github.com/banister/debug_inspector")
+    (license expat)))
-- 
2.8.3


[-- Attachment #3: Type: text/plain, Size: 53 bytes --]


Respectuflly,

-- 
Matthew Jordan
Sent with my mu4e