From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH 01/10] gnu: Add emacs-smex. Date: Fri, 03 Jun 2016 10:14:23 +0200 Message-ID: <87eg8e4rkw.fsf@gnu.org> References: <20160601140538.20311-1-dthompson2@worcester.edu> <87vb1slz61.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:46297) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b8kFU-0000ol-TY for guix-devel@gnu.org; Fri, 03 Jun 2016 04:14:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b8kFT-0001Wy-Ip for guix-devel@gnu.org; Fri, 03 Jun 2016 04:14:32 -0400 In-Reply-To: (David Thompson's message of "Thu, 2 Jun 2016 09:33:35 -0400") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: "Thompson, David" Cc: guix-devel , Alex Kost , David Thompson "Thompson, David" skribis: > On Thu, Jun 2, 2016 at 5:26 AM, Alex Kost wrote: >> David Thompson (2016-06-01 17:05 +0300) wrote: >> >>> From: David Thompson >>> >>> * gnu/packages/emacs.scm (emacs-smex): New variable. >>> --- >>> gnu/packages/emacs.scm | 22 ++++++++++++++++++++++ >>> 1 file changed, 22 insertions(+) >>> >>> >>> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm >>> index b7c0a1f..71f2f8b 100644 >>> --- a/gnu/packages/emacs.scm >>> +++ b/gnu/packages/emacs.scm >>> @@ -10,6 +10,7 @@ >>> ;;; Copyright =C2=A9 2015, 2016 Christopher Allan Webber >>> ;;; Copyright =C2=A9 2016 humanitiesNerd >>> ;;; Copyright =C2=A9 2016 Efraim Flashner >>> +;;; Copyright =C2=A9 2016 David Thompson >>> ;;; >>> ;;; This file is part of GNU Guix. >>> ;;; >>> @@ -1795,3 +1796,24 @@ work on lists, strings and vectors.") >>> Emacs default configuration in uncontroversial ways that nearly everyo= ne can >>> agree upon.") >>> (license license:gpl3+))) >>> + >>> +(define-public emacs-smex >>> + (package >>> + (name "emacs-smex") >>> + (version "3.0") >>> + (source (origin >>> + (method url-fetch) >>> + (uri (string-append "https://raw.githubusercontent.com" >>> + "/nonsequitur/smex/" version "/smex.= el")) >> >> Hm, I see in some packages you use these "githubusercontent" URLs >> instead of as >> we usually do for github. IIUC you did it to avoid extra files >> (".gitignore", etc.) in the final package directory, right? If so, I >> think it is not needed, I would still use a link to a tagged source code >> archive. Moreover I think it's a problem of emacs-build-system that >> these uninteresting files are not removed. >> >> Overall, I don't mind against "githubusercontent", I was just wondering. >> Actually, I think you found a good way how to pick the needed files to >> make several packages from a single repo (as you did for >> "ido-ubiquitous" and "ido-completing-read+"). > > Yes, I did this to avoid all sorts of unnecessary files making into > the store, as well as making it more closely mimic the single elisp > files that were released on MELPA or whatever. These URLs are stable, > so I thought it had a good clever/useful hack ratio. :) I think the downside is that the GitHub updater won=E2=80=99t be able to identify these, although I=E2=80=99m not 100% sure of that. Anyway, since the URLs are stable, it=E2=80=99s OK. Thanks, Ludo=E2=80=99.