From mboxrd@z Thu Jan 1 00:00:00 1970 From: John J Foerch Subject: Re: [PATCH] gnu: Add di. Date: Sun, 03 Jul 2016 18:03:01 -0400 Message-ID: <87eg7a9y7e.fsf@hecubus.retroj.net> References: <87poqvam4v.fsf@hecubus.retroj.net> <20160703210212.GA22355@jasmine> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:35898) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bJpUm-0004Fl-Tg for guix-devel@gnu.org; Sun, 03 Jul 2016 18:04:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bJpUh-0001rG-Oo for guix-devel@gnu.org; Sun, 03 Jul 2016 18:04:08 -0400 Received: from plane.gmane.org ([80.91.229.3]:51572) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bJpUh-0001r5-Hf for guix-devel@gnu.org; Sun, 03 Jul 2016 18:04:03 -0400 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1bJpUB-0005IN-P8 for guix-devel@gnu.org; Mon, 04 Jul 2016 00:03:31 +0200 Received: from 152.160.144.141 ([152.160.144.141]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 04 Jul 2016 00:03:31 +0200 Received: from jjfoerch by 152.160.144.141 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 04 Jul 2016 00:03:31 +0200 List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: guix-devel@gnu.org Leo Famulari writes: > On Sat, Jul 02, 2016 at 03:13:52PM -0400, John J Foerch wrote: >> * gnu/packages/admin.scm (di): New variable. > > Thanks! > >> + (arguments >> + `(#:phases >> + (modify-phases %standard-phases >> + (delete 'configure) >> + (delete 'check) > > Did you try setting `#:test-target "test"` in the arguments? The > Makefile has a test target. > I didn't know about that. I'll try it out. >> + (add-before 'build 'setup-environment >> + (lambda* (#:key outputs #:allow-other-keys) >> + (setenv "CC" "gcc") >> + (setenv "prefix" (assoc-ref outputs "out")) >> + #t))) > > Can you move these variables into #:make-flags? > >> + #:make-flags (list "-e"))) I don't think so. The main Makefile calls make in the 'C' directory, which has its own Makefile, so for the variables to be visible in that second make process, they need to be environment variables. > >> + (description >> + "'di' is a disk information utility, displaying everything >> +(and more) that your 'df' command does. It features the ability to display > > How about wrapping 'df' in texinfo like this? @code{df} Okay, will do. Thank you, -- John Foerch