From mboxrd@z Thu Jan  1 00:00:00 1970
From: Alex Kost <alezost@gmail.com>
Subject: Re: [PATCH] gnu: Add di.
Date: Mon, 04 Jul 2016 09:43:55 +0300
Message-ID: <87eg79kims.fsf@gmail.com>
References: <87poqvam4v.fsf@hecubus.retroj.net>
	<20160703210212.GA22355@jasmine> <87eg7a9y7e.fsf@hecubus.retroj.net>
	<87y45i83pi.fsf@hecubus.retroj.net>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53910)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alezost@gmail.com>) id 1bJxbr-0001Hi-9m
	for guix-devel@gnu.org; Mon, 04 Jul 2016 02:44:00 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alezost@gmail.com>) id 1bJxbo-0003E2-5w
	for guix-devel@gnu.org; Mon, 04 Jul 2016 02:43:59 -0400
Received: from mail-lf0-x229.google.com ([2a00:1450:4010:c07::229]:36418)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alezost@gmail.com>) id 1bJxbn-0003Dl-C5
	for guix-devel@gnu.org; Mon, 04 Jul 2016 02:43:56 -0400
Received: by mail-lf0-x229.google.com with SMTP id q132so110881666lfe.3
	for <guix-devel@gnu.org>; Sun, 03 Jul 2016 23:43:54 -0700 (PDT)
In-Reply-To: <87y45i83pi.fsf@hecubus.retroj.net> (John J. Foerch's message of
	"Sun, 03 Jul 2016 23:47:05 -0400")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: John J Foerch <jjfoerch@earthlink.net>
Cc: guix-devel@gnu.org

John J Foerch (2016-07-04 06:47 +0300) wrote:

> John J Foerch <jjfoerch@earthlink.net> writes:
>
>> Leo Famulari <leo@famulari.name> writes:
>>
>>> On Sat, Jul 02, 2016 at 03:13:52PM -0400, John J Foerch wrote:
>>>> * gnu/packages/admin.scm (di): New variable.
>>>
>>> Thanks!
>>>
>>>> +    (arguments
>>>> +     `(#:phases
>>>> +       (modify-phases %standard-phases
>>>> +         (delete 'configure)
>>>> +         (delete 'check)
>>>
>>> Did you try setting `#:test-target "test"` in the arguments? The
>>> Makefile has a test target.
>>>
>>
>> I didn't know about that.  I'll try it out.
>>
> A test relating to an included perl module Filesys::di fails.  I hadn't
> intended to include that module in the package, as all I'm interested in
> is the 'di' binary.  Given that, I would suggest that we bypass the
> tests.

As for me, I would also disable the tests.  All these handmade Makefiles
in all sub-directories are a nightmare.  I think trying to figure out
what is needed to run the tests doesn't worth it.

Also don't forget to add a copyright line for yourself in the beginning
of "admin.scm".

-- 
Alex