From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Kost Subject: Re: [PATCH 17/17] gnu: Add emacs-solarized-theme. Date: Wed, 20 Jul 2016 10:07:07 +0300 Message-ID: <87eg6og544.fsf@gmail.com> References: <20160712210514.21310-1-rekado@elephly.net> <20160712210514.21310-18-rekado@elephly.net> <874m7rypf1.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:60702) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bPlb9-00043I-6C for guix-devel@gnu.org; Wed, 20 Jul 2016 03:07:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bPlb4-0002hs-57 for guix-devel@gnu.org; Wed, 20 Jul 2016 03:07:14 -0400 Received: from mail-lf0-x243.google.com ([2a00:1450:4010:c07::243]:36638) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bPlb3-0002ho-Sy for guix-devel@gnu.org; Wed, 20 Jul 2016 03:07:10 -0400 Received: by mail-lf0-x243.google.com with SMTP id 33so2979950lfw.3 for ; Wed, 20 Jul 2016 00:07:09 -0700 (PDT) In-Reply-To: <874m7rypf1.fsf@gmail.com> (Alex Kost's message of "Fri, 15 Jul 2016 16:57:38 +0300") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ricardo Wurmus Cc: guix-devel@gnu.org Alex Kost (2016-07-15 16:57 +0300) wrote: > Ricardo Wurmus (2016-07-13 00:05 +0300) wrote: > >> * gnu/packages/emacs.scm (emacs-solarized-theme): New variable. >> --- >> gnu/packages/emacs.scm | 24 ++++++++++++++++++++++++ >> 1 file changed, 24 insertions(+) >> >> >> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm >> index 2c92756..4f2d5ca 100644 >> --- a/gnu/packages/emacs.scm >> +++ b/gnu/packages/emacs.scm >> @@ -2086,6 +2086,30 @@ number.") >> It is built on top of the custom theme support in Emacs 24 or later.") >> (license license:gpl3+))) >> >> +(define-public emacs-solarized-theme >> + (package >> + (name "emacs-solarized-theme") >> + (version "1.2.2") >> + (source (origin >> + (method url-fetch) >> + (uri (string-append "https://github.com/bbatsov/solarized-emacs/" >> + "archive/v" version ".tar.gz")) >> + (file-name (string-append name "-" version ".tar.gz")) >> + (sha256 >> + (base32 >> + "1ha3slc6d9wi9ilkhmwrzkvf308n6ph7b0k69pk369s9304awxzx")))) >> + (build-system emacs-build-system) >> + (propagated-inputs >> + `(("emacs-dash" ,emacs-dash) >> + ("emacs-f" ,emacs-f) >> + ("emacs-s" ,emacs-s))) > > There is no need in "f" and "s", this package depends only on "dash" > library. Otherwise LGTM. you seem to forget to remove "f" and "s" in commit 012c8b3 :-) -- Alex