From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kei Kebreau Subject: Re: [PATCH] gnu: Add python-pygame. Date: Sat, 30 Jul 2016 10:26:00 -0400 Message-ID: <87eg6bnqx3.fsf@openmailbox.org> References: <87bn1grvuq.fsf@openmailbox.org> <8760rorv57.fsf@openmailbox.org> <8760rngrnd.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:40377) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bTVDY-0008NT-Ec for guix-devel@gnu.org; Sat, 30 Jul 2016 10:26:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bTVDT-0006qa-Op for guix-devel@gnu.org; Sat, 30 Jul 2016 10:26:18 -0400 In-Reply-To: <8760rngrnd.fsf@gnu.org> (Roel Janssen's message of "Sat, 30 Jul 2016 15:52:06 +0200") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Roel Janssen Cc: guix-devel@gnu.org --=-=-= Content-Type: text/plain Roel Janssen writes: > Kei Kebreau writes: > >> Kei Kebreau writes: >> >>> The python-pygame patch as promised. Note that it requires the >>> application of the most recently submitted libsmpeg patch. Would anyone >>> else like to test this? :-) > > I've succesfully built both the libsmpeg patch and python-pygame. > >> Please disregard the earlier patch. I had to add the other licenses and >> a description to the definition. Thanks to Roel for sharing a pygame >> definition! > > Thank you for getting it to work! I only have one comment: > >>+ (system* "ln" "--symbolic" "Setup.in" "Setup"))))))) >>+ ;; The default tries to install libraries into the python directory. >>+ ;; Using --install-lib, we can provide the correct path. >>+ (native-inputs >>+ `(("python-setuptools" ,python-setuptools))) > > The comment seems to be out of place. I don't even know where it > belongs to anymore. Was this for another build phase customization? (it > seems to because of the indentation..). > > Thank you. > > Kind regards, > Roel Janssen Indeed, that comment was left over from the install phase you replaced when you used the gnu-build-system. I'll correct it before I push the changes upstream. Unless anyone else has any input, I'll be pushing this later today! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXnLj5AAoJEOal7jwZRnoNGiQQAMA4figjYF6fWB43jsSCg+3n rInzCq18zz6X+ALYtSN0aWfzt1FIZGXuaz093hYnuIg94StyU6MgLxZWD7BWX6ZS iUNDuKv0I6pH6YzSi4PK/TdSrYxNEA1P2rUviWvFuQtQeNcXdutzM27HSGFge1p/ +uJRmzmAYisLB4XM8nDk97AhHpOwdHDxK6VHg64esDYbG2QhZP3MjXv4LEC5wQrw VLMpH6pyREMZAK9p3dydb96SMalkoNEpGBNXkre+idQ3GmEiwl9CAO3ZYUSBzgrE DyBV/YBC1+Ebwl5tU4bezC76YojdoW2wECMCxk3F35MLTutFidSc6s6mmtOYtInm iy5y7pmHKi3qv6Nb2yk9maE6WBAogv1tcAiNuB/1aK0YKfgBbw3JIGoqtkv1LBxm QAGeeq+k9t+QDJiTCuH7xmsOtALy2fZ8NqQ1Ll3HBzZtDG4tojy2Ya37E77e0HdF 2oWa+R1TJG1BmUZGdS6YBrv5c952FtecbOOYTjpv+k5aB3cA0/RqTTh7Zn/Dp8st dwZiDAvdkVNNx5YXvOq/MZ7NPkiGBwKstLwRz2GJXwRnfgtPDjSglxmIovXOsnhb wb9JxzNHl6k2FdQKMTClIlldUpRfV91i29sk8wmwIy/gtB9JLwsipwUJK/fd7oRA cBsXZPZ9AM/CgD8EpFqU =f+Qn -----END PGP SIGNATURE----- --=-=-=--