From: ludo@gnu.org (Ludovic Courtès)
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add u-boot.
Date: Thu, 01 Sep 2016 14:11:38 +0200 [thread overview]
Message-ID: <87eg53q0p1.fsf@gnu.org> (raw)
In-Reply-To: <20160831225534.58cf56b9@scratchpost.org> (Danny Milosavljevic's message of "Wed, 31 Aug 2016 22:55:34 +0200")
Hi Danny!
Danny Milosavljevic <dannym@scratchpost.org> skribis:
> On Wed, 31 Aug 2016 22:40:57 +0200
> ludo@gnu.org (Ludovic Courtès) wrote:
>
>> > + (lambda* (#:key outputs make-flags #:allow-other-keys)
>> > + (let ((configname (string-append ,board "_defconfig")))
>>
>> Should be ‘config-name’ per our conventions, but ‘config’ is probably
>> enough.
>>
>> > + (if (file-exists? (string-append "configs/" configname))
>> > + (zero? (apply system* "make" `(,@make-flags ,configname)))
>> > + (begin
>> > + (display "Invalid boardname. Valid boardnames would have been:")
>>
>> “board name” (two words).
>
>> > + (copy-file file-path target-file-path)))
>> > + uboot-files)))))))))
>>
>> s/-path//
>
> For the record, a filename (or file path) is something completely different from a file. It makes no sense to call a filename "file". Likewise, a boardname is the name of a board. It's not the board. A configname is the name of a config [file]. "config" would be the configuration itself.
>
> To develop this habit has taken a long time for me and it has paid off well.
I guess it’s just a matter of convention, so no argument here. :-)
GNU’s convention is to call “file name” the name of a file (not
“filepath”, not “path”, not “filename”); in Scheme, that would give
“file-name” as the variable name, which I often shorten to “file”
because there are no files in Scheme, only I/O ports.
Buy yeah, I’m nitpicking, or maybe even “bikeshedding”. :-)
Ludo’.
next prev parent reply other threads:[~2016-09-01 12:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-29 14:48 [PATCH] gnu: Add dtc David Craven
2016-08-29 14:53 ` David Craven
2016-08-29 17:02 ` Danny Milosavljevic
2016-08-29 16:16 ` [PATCH] gnu: Add u-boot David Craven
2016-08-29 18:27 ` Danny Milosavljevic
2016-08-29 18:30 ` Danny Milosavljevic
2016-08-31 20:40 ` Ludovic Courtès
2016-08-31 20:55 ` Danny Milosavljevic
2016-08-31 21:07 ` David Craven
2016-09-01 12:11 ` Ludovic Courtès [this message]
2016-08-31 20:44 ` [PATCH] gnu: Add dtc Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eg53q0p1.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=dannym@scratchpost.org \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).