From: Roel Janssen <roel@gnu.org>
To: Leo Famulari <leo@famulari.name>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH v4 2/3] gnu: Make ldc work again
Date: Tue, 13 Sep 2016 22:01:43 +0200 [thread overview]
Message-ID: <87eg4nsh5k.fsf@gnu.org> (raw)
In-Reply-To: <20160913192549.GE5986@jasmine>
Leo Famulari writes:
> On Tue, Sep 13, 2016 at 09:20:05PM +0200, Ricardo Wurmus wrote:
>>
>> Leo Famulari <leo@famulari.name> writes:
>>
>> > On Tue, Sep 13, 2016 at 12:53:39PM -0400, Leo Famulari wrote:
>> >> On Tue, Sep 13, 2016 at 12:30:41PM +0200, Danny Milosavljevic wrote:
>> >> > * gnu/packages/ldc.scm (ldc): Added substitution. Added zlib input. Fix llvm and clang inputs to 3.7.
>> >>
>> >> LDC built with this patch. I'm currently in the test suite. If it passes
>> >> on my computer, I'd like to push this patch unless there are objections.
>> >
>> > The test suite passed. If there are no more comments in the next day or
>> > two, I will push this patch with some edits to the commit message.
>>
>> The patch looks good to me (aside from the commit message).
>
> Okay, considering the comments from you and Roel, I pushed with an
> altered commit message as 812b3c1f8a3717fd9fc540663912c5e9a144db5b.
It built fine here. Thanks for pushing.
Kind regards,
Roel Janssen
next prev parent reply other threads:[~2016-09-13 20:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-13 10:30 [PATCH v4 0/3] Fix ldc Danny Milosavljevic
2016-09-13 10:30 ` [PATCH v4 1/3] gnu: Add python-lit, python2-lit Danny Milosavljevic
2016-09-13 16:42 ` Leo Famulari
2016-09-13 10:30 ` [PATCH v4 2/3] gnu: Make ldc work again Danny Milosavljevic
2016-09-13 16:53 ` Leo Famulari
2016-09-13 18:09 ` Leo Famulari
2016-09-13 19:20 ` Ricardo Wurmus
2016-09-13 19:25 ` Leo Famulari
2016-09-13 20:01 ` Roel Janssen [this message]
2016-09-13 19:05 ` Roel Janssen
2016-09-13 10:30 ` [PATCH v4 3/3] gnu: Update ldc to 0.17.1 Danny Milosavljevic
2016-09-13 16:55 ` Leo Famulari
2016-09-13 19:44 ` Danny Milosavljevic
2016-09-13 19:25 ` Efraim Flashner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eg4nsh5k.fsf@gnu.org \
--to=roel@gnu.org \
--cc=guix-devel@gnu.org \
--cc=leo@famulari.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).