From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: Expat regression fix for master branch Date: Tue, 13 Sep 2016 23:54:09 +0200 Message-ID: <87eg4nqxdq.fsf@gnu.org> References: <20160912213515.GA15911@jasmine> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:52261) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bjvej-0000ws-9P for guix-devel@gnu.org; Tue, 13 Sep 2016 17:54:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bjvef-00072N-1C for guix-devel@gnu.org; Tue, 13 Sep 2016 17:54:16 -0400 In-Reply-To: <20160912213515.GA15911@jasmine> (Leo Famulari's message of "Mon, 12 Sep 2016 17:35:15 -0400") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Leo Famulari Cc: guix-devel@gnu.org Hello, Leo Famulari skribis: > This patch applies an upstream patch for a regression caused by the fix=20 > for CVE-2016-0718. > > Apparently, the bug only manifests when building with -DXML_UNICODE, > which I don't think our package does. I rebuilt it with --check and can confirm that XML_UNICODE is not defined. =E2=80=98README=E2=80=99 mentions it: --8<---------------cut here---------------start------------->8--- If you are interested in building Expat to provide document information in UTF-16 encoding rather than the default UTF-8, follow these instructions (after having run "make distclean"): 1. For UTF-16 output as unsigned short (and version/error strings as char), run: ./configure CPPFLAGS=3D-DXML_UNICODE --8<---------------cut here---------------end--------------->8--- It=E2=80=99s enough to have the patch in =E2=80=98core-updates=E2=80=99 onl= y, but I could go either way. WDYT? Ludo=E2=80=99.