unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Ricardo Wurmus <rekado@elephly.net>
To: 宋文武 <iyzsong@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add Mr. Rescue.
Date: Sun, 18 Sep 2016 10:17:22 +0200	[thread overview]
Message-ID: <87eg4hr59p.fsf@elephly.net> (raw)
In-Reply-To: <20160917132405.17071-1-iyzsong@gmail.com>


宋文武 <iyzsong@gmail.com> writes:

> * gnu/packages/games.scm (mrrescue): New variable.
> ---
>  gnu/packages/games.scm | 48 ++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 48 insertions(+)
>
> diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
> index d386e2c..8d321fc 100644
> --- a/gnu/packages/games.scm
> +++ b/gnu/packages/games.scm
> @@ -2856,3 +2856,51 @@ programmers may also add their own favorite language.")
>  application that locks the keyboard and mouse and instead displays bright
>  colors, pictures, and sounds.")
>      (license license:gpl3+)))
> +
> +(define-public mrrescue
> +  (package
> +    (name "mrrescue")
> +    (version "1.02e")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append
> +                    "https://github.com/SimonLarsen/mrrescue/releases/"
> +                    "download/" version "/" name version ".love"))
> +              (file-name (string-append name "-" version ".love"))

What is this file?  Are these sources or is this a binary image?

> +              (sha256
> +               (base32
> +                "0jwzbwkgp1l5ia6c7s760gmdirbsncp6nfqp7vqdqsfb63la9gl2"))))
> +    (build-system trivial-build-system)
> +    (arguments
> +     '(#:modules ((guix build utils))
> +       #:builder
> +       (begin
> +         (use-modules (guix build utils))
> +         (let* ((out     (assoc-ref %outputs "out"))
> +                (bindir  (string-append out "/bin"))
> +                (prog    (string-append bindir "/mrrescue"))
> +                (source  (assoc-ref %build-inputs "source"))
> +                (guile   (string-append (assoc-ref %build-inputs "guile")
> +                                        "/bin/guile"))
> +                (love    (string-append (assoc-ref %build-inputs "love")
> +                                        "/bin/love")))
> +           (mkdir-p bindir)
> +           (with-output-to-file prog
> +             (lambda ()
> +               (format #t "#!~a --no-auto-compile~%!#~%" guile)
> +               (write `(execl ,love "mrrescue" ,source))
> +               (newline)))
> +           (chmod prog #o755)
> +           #t))))

Is the “.love” file the source archive?  In the repository I only see
“.lua” files.  Shouldn’t we compile them from source?

~~ Ricardo

  reply	other threads:[~2016-09-18  8:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-17 13:24 [PATCH] gnu: Add Mr. Rescue 宋文武
2016-09-18  8:17 ` Ricardo Wurmus [this message]
2016-09-18 11:24   ` 宋文武
2016-09-18  9:07 ` Hartmut Goebel
2016-09-18 11:33   ` 宋文武

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87eg4hr59p.fsf@elephly.net \
    --to=rekado@elephly.net \
    --cc=guix-devel@gnu.org \
    --cc=iyzsong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).