From: James Richardson <james@jamestechnotes.com>
To: guix-devel@gnu.org
Subject: Re: [Patch] add keychain
Date: Sat, 24 Sep 2016 13:24:56 -0400 [thread overview]
Message-ID: <87eg49mcrb.fsf@thor.jamestechnotes.com> (raw)
In-Reply-To: <57E5050B.8030406@crazy-compilers.com>
Hartmut Goebel writes:
Thank you for the feedback! Much appreciated!
> Am 22.09.2016 um 14:10 schrieb James Richardson:
>> * gnu/packages/keychain.scm: Add new file.
>
> I suggest putting this into some other file, e.g. crypto.scm or ssh.scm.
> Otherwise we have a file for a single package.
I wasn't sure of the policy. I will move it to one of these files.
>
>> * gnu/packages/keychain.scm: (keychain): New variable.
>
> If you stay with the separate file, this line is not needed.
>
>> + #:builder (begin
>> + (use-modules (guix build utils))
>> + (let ((bin-dir (string-append %output "/bin"))
>> + (man1-dir (string-append %output "/share/man/man1"))
>> + (tar (string-append
>> + (assoc-ref %build-inputs "tar")
>> + "/bin/tar"))
>> + (bzip2 (assoc-ref %build-inputs "bzip2"))
> You may want to have a look at audio.scm:freepats for a bit shorter and
> more obvious code.
I will take a look.
>
>> + (mkdir-p bin-dir)
>> + (mkdir-p man1-dir)
>> + (setenv "PATH" (string-append bzip2 "/bin"))
>> + (system* tar "xfv" source)
>
> Please unpack the source first, the code is more obvious then.
>> + (copy-file (string-append ,name "-"
>> + ,version "/keychain.1")
> If you run this using "with-directory-excursion", the code is more
> obvious and simpler.
>> + (string-append man1-dir "/keychain.1"))
>> + (copy-file (string-append ,name "-"
>> + ,version "/keychain")
>> + (string-append bin-dir "/keychain"))))))
>
> You can use install-file and save the make-p above.
>> + (native-inputs `(("bzip2" ,bzip2)
>> + ("tar" ,tar)
I wasn't aware of of install-file. I will make these updates.
>
> Please warp like this:
>
> + (native-inputs
> + `(("bzip2" ,bzip2)
> + ("tar" ,tar)
>
>
>> + ("source" ,source)))
>
>
> No need for listing the source here.
>
I will work on the wording.
>> + (synopsis "Key manager for OpenSSH")
>
> Not only for *open*ssh, but for other implementations, too. And für
> GnuPG-Agent, Maybe even talk abpout the Agent in the synopsis.
>
> Keychains itself says it is a "agent manager".
>
>> + (description
>> + "Keychain is an OpenSSH key manager, typically run from
>> +~/.bash_profile. When keychain is run, it checks for a running ssh-agent,
>> +otherwise it starts one. It saves the ssh-agent environment variables to
>> +~/.keychain/$HOSTNAME-sh, so that subsequent logins and
>> +non-interactive shells such as cron jobs can source the file and make
>> +passwordless ssh connections. In addition, when keychain runs, it
>> +verifies that the key files specified on the command-line are known to
>> +ssh-agent, otherwise it loads them, prompting you for a password
>> +if necessary.")
>
>
> The text above is a details workflow description. For me the text form
> the keychain.spec-file is more meaningful. Maybe you want to combine them?
>
> Keychain is a manager for OpenSSH, ssh.com, Sun SSH and GnuPG agents.
> It acts as a front-end to the agents, allowing you to easily have one
> long-running agent process per system, rather than per login session.
> This reduces the number of times you need to enter your passphrase
> from once per new login session to once every time your local machine
> is rebooted.
I'll try to have these changes in the next few days. Thank you for the
review.
--
James Richardson
next prev parent reply other threads:[~2016-09-24 17:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-22 12:10 [Patch] add keychain James Richardson
2016-09-23 10:33 ` Hartmut Goebel
2016-09-24 17:24 ` James Richardson [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-09-22 11:46 [Patch]: " James Richardson
2016-09-22 10:03 [Patch] Add keychain james
2016-09-22 6:07 james
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eg49mcrb.fsf@thor.jamestechnotes.com \
--to=james@jamestechnotes.com \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).