* [PATCH] gnu: Add python-whoosh.
@ 2016-10-15 13:01 Ricardo Wurmus
2016-10-15 21:05 ` Kei Kebreau
0 siblings, 1 reply; 5+ messages in thread
From: Ricardo Wurmus @ 2016-10-15 13:01 UTC (permalink / raw)
To: guix-devel
* gnu/packages/python.scm (python-whoosh, python2-whoosh): New variables.
---
gnu/packages/python.scm | 30 ++++++++++++++++++++++++++++++
1 file changed, 30 insertions(+)
diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 6207896..69c7d36 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -8823,6 +8823,36 @@ library.")
(native-inputs `(("python2-setuptools" ,python2-setuptools)
,@(package-native-inputs responses))))))
+(define-public python-whoosh
+ (package
+ (name "python-whoosh")
+ (version "2.7.4")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (pypi-uri "Whoosh" version))
+ (sha256
+ (base32
+ "10qsqdjpbc85fykc1vgcs8xwbgn4l2l52c8d83xf1q59pwyn79bw"))))
+ (build-system python-build-system)
+ (native-inputs
+ `(("python-setuptools" ,python-setuptools)
+ ("python-pytest" ,python-pytest)))
+ (home-page "http://bitbucket.org/mchaput/whoosh")
+ (synopsis "Full text indexing, search, and spell checking library")
+ (description
+ "Whoosh is a fast, pure-Python full text indexing, search, and spell
+checking library.")
+ (license license:bsd-2)))
+
+(define-public python2-whoosh
+ (let ((whoosh (package-with-python2 (strip-python2-variant python-whoosh))))
+ (package (inherit whoosh)
+ (propagated-inputs
+ `(("python2-backport-ssl-match-hostname"
+ ,python2-backport-ssl-match-hostname)
+ ,@(package-propagated-inputs whoosh))))))
+
(define-public python-pathlib
(package
(name "python-pathlib")
--
2.10.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] gnu: Add python-whoosh.
2016-10-15 13:01 [PATCH] gnu: Add python-whoosh Ricardo Wurmus
@ 2016-10-15 21:05 ` Kei Kebreau
2016-10-15 21:48 ` Marius Bakke
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Kei Kebreau @ 2016-10-15 21:05 UTC (permalink / raw)
To: Ricardo Wurmus; +Cc: guix-devel
[-- Attachment #1: Type: text/plain, Size: 1895 bytes --]
Ricardo Wurmus <rekado@elephly.net> writes:
> * gnu/packages/python.scm (python-whoosh, python2-whoosh): New variables.
> ---
> gnu/packages/python.scm | 30 ++++++++++++++++++++++++++++++
> 1 file changed, 30 insertions(+)
>
> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> index 6207896..69c7d36 100644
> --- a/gnu/packages/python.scm
> +++ b/gnu/packages/python.scm
> @@ -8823,6 +8823,36 @@ library.")
> (native-inputs `(("python2-setuptools" ,python2-setuptools)
> ,@(package-native-inputs responses))))))
>
> +(define-public python-whoosh
> + (package
> + (name "python-whoosh")
> + (version "2.7.4")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (pypi-uri "Whoosh" version))
> + (sha256
> + (base32
> + "10qsqdjpbc85fykc1vgcs8xwbgn4l2l52c8d83xf1q59pwyn79bw"))))
> + (build-system python-build-system)
> + (native-inputs
> + `(("python-setuptools" ,python-setuptools)
> + ("python-pytest" ,python-pytest)))
> + (home-page "http://bitbucket.org/mchaput/whoosh")
> + (synopsis "Full text indexing, search, and spell checking library")
> + (description
> + "Whoosh is a fast, pure-Python full text indexing, search, and spell
> +checking library.")
> + (license license:bsd-2)))
> +
> +(define-public python2-whoosh
> + (let ((whoosh (package-with-python2 (strip-python2-variant python-whoosh))))
> + (package (inherit whoosh)
> + (propagated-inputs
> + `(("python2-backport-ssl-match-hostname"
> + ,python2-backport-ssl-match-hostname)
> + ,@(package-propagated-inputs whoosh))))))
> +
> (define-public python-pathlib
> (package
> (name "python-pathlib")
Linting works fine, but outputs differ on each build. Is this a common
problem with python packages?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] gnu: Add python-whoosh.
2016-10-15 21:05 ` Kei Kebreau
@ 2016-10-15 21:48 ` Marius Bakke
2016-10-15 22:19 ` Leo Famulari
2016-10-16 11:15 ` Ricardo Wurmus
2 siblings, 0 replies; 5+ messages in thread
From: Marius Bakke @ 2016-10-15 21:48 UTC (permalink / raw)
To: Kei Kebreau, Ricardo Wurmus; +Cc: guix-devel
Kei Kebreau <kei@openmailbox.org> writes:
> Ricardo Wurmus <rekado@elephly.net> writes:
>
>> * gnu/packages/python.scm (python-whoosh, python2-whoosh): New variables.
>> ---
>> gnu/packages/python.scm | 30 ++++++++++++++++++++++++++++++
>> 1 file changed, 30 insertions(+)
>>
>> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
>> index 6207896..69c7d36 100644
>> --- a/gnu/packages/python.scm
>> +++ b/gnu/packages/python.scm
>> @@ -8823,6 +8823,36 @@ library.")
>> (native-inputs `(("python2-setuptools" ,python2-setuptools)
>> ,@(package-native-inputs responses))))))
>>
>> +(define-public python-whoosh
>> + (package
>> + (name "python-whoosh")
>> + (version "2.7.4")
>> + (source
>> + (origin
>> + (method url-fetch)
>> + (uri (pypi-uri "Whoosh" version))
>> + (sha256
>> + (base32
>> + "10qsqdjpbc85fykc1vgcs8xwbgn4l2l52c8d83xf1q59pwyn79bw"))))
>> + (build-system python-build-system)
>> + (native-inputs
>> + `(("python-setuptools" ,python-setuptools)
>> + ("python-pytest" ,python-pytest)))
>> + (home-page "http://bitbucket.org/mchaput/whoosh")
>> + (synopsis "Full text indexing, search, and spell checking library")
>> + (description
>> + "Whoosh is a fast, pure-Python full text indexing, search, and spell
>> +checking library.")
>> + (license license:bsd-2)))
>> +
>> +(define-public python2-whoosh
>> + (let ((whoosh (package-with-python2 (strip-python2-variant python-whoosh))))
>> + (package (inherit whoosh)
>> + (propagated-inputs
>> + `(("python2-backport-ssl-match-hostname"
>> + ,python2-backport-ssl-match-hostname)
>> + ,@(package-propagated-inputs whoosh))))))
>> +
>> (define-public python-pathlib
>> (package
>> (name "python-pathlib")
>
> Linting works fine, but outputs differ on each build. Is this a common
> problem with python packages?
Yes, it's a common problem with python packages. This should be largely
fixed by the new python build system however.
Wrt the patch, setuptools is not required for the python3 variant. But
since it will no longer be required for python2 either after the new
build system, I think it's okay to keep it for now, since it would
complicate the patch a lot.
LGTM.
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] gnu: Add python-whoosh.
2016-10-15 21:05 ` Kei Kebreau
2016-10-15 21:48 ` Marius Bakke
@ 2016-10-15 22:19 ` Leo Famulari
2016-10-16 11:15 ` Ricardo Wurmus
2 siblings, 0 replies; 5+ messages in thread
From: Leo Famulari @ 2016-10-15 22:19 UTC (permalink / raw)
To: Kei Kebreau; +Cc: guix-devel
[-- Attachment #1: Type: text/plain, Size: 2388 bytes --]
On Sat, Oct 15, 2016 at 05:05:23PM -0400, Kei Kebreau wrote:
> Ricardo Wurmus <rekado@elephly.net> writes:
>
> > * gnu/packages/python.scm (python-whoosh, python2-whoosh): New variables.
> > ---
> > gnu/packages/python.scm | 30 ++++++++++++++++++++++++++++++
> > 1 file changed, 30 insertions(+)
> >
> > diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> > index 6207896..69c7d36 100644
> > --- a/gnu/packages/python.scm
> > +++ b/gnu/packages/python.scm
> > @@ -8823,6 +8823,36 @@ library.")
> > (native-inputs `(("python2-setuptools" ,python2-setuptools)
> > ,@(package-native-inputs responses))))))
> >
> > +(define-public python-whoosh
> > + (package
> > + (name "python-whoosh")
> > + (version "2.7.4")
> > + (source
> > + (origin
> > + (method url-fetch)
> > + (uri (pypi-uri "Whoosh" version))
> > + (sha256
> > + (base32
> > + "10qsqdjpbc85fykc1vgcs8xwbgn4l2l52c8d83xf1q59pwyn79bw"))))
> > + (build-system python-build-system)
> > + (native-inputs
> > + `(("python-setuptools" ,python-setuptools)
> > + ("python-pytest" ,python-pytest)))
> > + (home-page "http://bitbucket.org/mchaput/whoosh")
> > + (synopsis "Full text indexing, search, and spell checking library")
> > + (description
> > + "Whoosh is a fast, pure-Python full text indexing, search, and spell
> > +checking library.")
> > + (license license:bsd-2)))
> > +
> > +(define-public python2-whoosh
> > + (let ((whoosh (package-with-python2 (strip-python2-variant python-whoosh))))
> > + (package (inherit whoosh)
> > + (propagated-inputs
> > + `(("python2-backport-ssl-match-hostname"
> > + ,python2-backport-ssl-match-hostname)
> > + ,@(package-propagated-inputs whoosh))))))
> > +
> > (define-public python-pathlib
> > (package
> > (name "python-pathlib")
>
> Linting works fine, but outputs differ on each build. Is this a common
> problem with python packages?
The Python 3.4.3 (what we have on master) bytecode compiler puts
timestamps in the bytecode:
https://bugs.gnu.org/22533
I think this issue will be fixed when we upgrade to Python 3.5.2.
And, IIRC, our version of Sphinx puts timestamps in man pages. This is
also fixed in more recent versions of Sphinx, again IIRC.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] gnu: Add python-whoosh.
2016-10-15 21:05 ` Kei Kebreau
2016-10-15 21:48 ` Marius Bakke
2016-10-15 22:19 ` Leo Famulari
@ 2016-10-16 11:15 ` Ricardo Wurmus
2 siblings, 0 replies; 5+ messages in thread
From: Ricardo Wurmus @ 2016-10-16 11:15 UTC (permalink / raw)
To: Kei Kebreau; +Cc: guix-devel
Kei Kebreau <kei@openmailbox.org> writes:
> Ricardo Wurmus <rekado@elephly.net> writes:
>
>> * gnu/packages/python.scm (python-whoosh, python2-whoosh): New variables.
Thanks for the review (and for checking reproducibility). This has been
pushed to master as b7afd01893ef2f08049810bd63784e915a8a2f9a.
~~ Ricardo
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-10-16 11:15 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-15 13:01 [PATCH] gnu: Add python-whoosh Ricardo Wurmus
2016-10-15 21:05 ` Kei Kebreau
2016-10-15 21:48 ` Marius Bakke
2016-10-15 22:19 ` Leo Famulari
2016-10-16 11:15 ` Ricardo Wurmus
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).