From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marius Bakke Subject: Re: [PATCH] gnu: Add python-whoosh. Date: Sat, 15 Oct 2016 22:48:43 +0100 Message-ID: <87eg3hjnb8.fsf@duckhunt.i-did-not-set--mail-host-address--so-tickle-me> References: <20161015130143.5185-1-rekado@elephly.net> <871szhcoh8.fsf@openmailbox.org> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:39618) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bvWp0-00048K-3h for guix-devel@gnu.org; Sat, 15 Oct 2016 17:48:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bvWov-0005mo-M6 for guix-devel@gnu.org; Sat, 15 Oct 2016 17:48:50 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:46603) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1bvWov-0005mc-Hy for guix-devel@gnu.org; Sat, 15 Oct 2016 17:48:45 -0400 In-Reply-To: <871szhcoh8.fsf@openmailbox.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Kei Kebreau , Ricardo Wurmus Cc: guix-devel@gnu.org Kei Kebreau writes: > Ricardo Wurmus writes: > >> * gnu/packages/python.scm (python-whoosh, python2-whoosh): New variables. >> --- >> gnu/packages/python.scm | 30 ++++++++++++++++++++++++++++++ >> 1 file changed, 30 insertions(+) >> >> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm >> index 6207896..69c7d36 100644 >> --- a/gnu/packages/python.scm >> +++ b/gnu/packages/python.scm >> @@ -8823,6 +8823,36 @@ library.") >> (native-inputs `(("python2-setuptools" ,python2-setuptools) >> ,@(package-native-inputs responses)))))) >> >> +(define-public python-whoosh >> + (package >> + (name "python-whoosh") >> + (version "2.7.4") >> + (source >> + (origin >> + (method url-fetch) >> + (uri (pypi-uri "Whoosh" version)) >> + (sha256 >> + (base32 >> + "10qsqdjpbc85fykc1vgcs8xwbgn4l2l52c8d83xf1q59pwyn79bw")))) >> + (build-system python-build-system) >> + (native-inputs >> + `(("python-setuptools" ,python-setuptools) >> + ("python-pytest" ,python-pytest))) >> + (home-page "http://bitbucket.org/mchaput/whoosh") >> + (synopsis "Full text indexing, search, and spell checking library") >> + (description >> + "Whoosh is a fast, pure-Python full text indexing, search, and spell >> +checking library.") >> + (license license:bsd-2))) >> + >> +(define-public python2-whoosh >> + (let ((whoosh (package-with-python2 (strip-python2-variant python-whoosh)))) >> + (package (inherit whoosh) >> + (propagated-inputs >> + `(("python2-backport-ssl-match-hostname" >> + ,python2-backport-ssl-match-hostname) >> + ,@(package-propagated-inputs whoosh)))))) >> + >> (define-public python-pathlib >> (package >> (name "python-pathlib") > > Linting works fine, but outputs differ on each build. Is this a common > problem with python packages? Yes, it's a common problem with python packages. This should be largely fixed by the new python build system however. Wrt the patch, setuptools is not required for the python3 variant. But since it will no longer be required for python2 either after the new build system, I think it's okay to keep it for now, since it would complicate the patch a lot. LGTM.