From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
To: ng0 <ngillmann@runbox.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 2/4] gnu: Add libpsyc.
Date: Sun, 30 Oct 2016 06:57:50 +0100 [thread overview]
Message-ID: <87eg2y9y5d.fsf@mdc-berlin.de> (raw)
In-Reply-To: <20160929103810.10273-2-ngillmann@runbox.com>
ng0 <ngillmann@runbox.com> writes:
> * gnu/packages/psyc.scm (libpsyc): New variable.
> ---
> gnu/packages/psyc.scm | 41 +++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 41 insertions(+)
>
> diff --git a/gnu/packages/psyc.scm b/gnu/packages/psyc.scm
> index 4d53dfd..253fa64 100644
> --- a/gnu/packages/psyc.scm
> +++ b/gnu/packages/psyc.scm
> @@ -21,7 +21,10 @@
> #:use-module ((guix licenses) #:prefix license:)
> #:use-module (guix packages)
> #:use-module (guix build-system perl)
> + #:use-module (guix build-system gnu)
> #:use-module (gnu packages)
> + #:use-module (gnu packages admin)
> + #:use-module (gnu packages linux)
> #:use-module (gnu packages ncurses)
> #:use-module (gnu packages perl)
> #:use-module (gnu packages web))
> @@ -103,3 +106,41 @@ for @uref{https://torproject.org,tor} router) and many more.")
> license:public-domain
> ;; bin/psycplay states AGPL with no version:
> license:agpl3+))))
> +
> +(define-public libpsyc
> + (package
> + (name "libpsyc")
> + (version "20160913")
> + (source (origin
> + (method url-fetch)
> + (uri (string-append "http://www.psyced.org/files/"
> + name "-" version ".tar.xz"))
> + (sha256
> + (base32
> + "14q89fxap05ajkfn20rnhc6b1h4i3i2adyr7y6hs5zqwb2lcmc1p"))))
> + (build-system gnu-build-system)
> + (native-inputs
> + `(("perl" ,perl)
> + ("netcat" ,netcat)
> + ("procps" ,procps)))
> + (arguments
> + `(#:make-flags
> + (list "CC=gcc"
> + (string-append "PREFIX=" (assoc-ref %outputs "out")))
> + #:phases
> + (modify-phases %standard-phases
> + ;; The rust bindings are the only ones in use, the lpc bindings
> + ;; are in psyclpc. The other bindings are not used by anything,
> + ;; the chances are high that the bindings do not even work,
> + ;; therefore we do not include them.
> + ;; TODO: Get a cargo build system in Guix.
> + (delete 'configure)))) ; no configure script
> + (home-page "http://about.psyc.eu/libpsyc")
> + (description
> + "@code{libpsyc} is a PSYC library in C which implements
> +core aspects of PSYC, useful for all kinds of clients and servers
> +including psyced.")
> + (synopsis "PSYC library in C")
> + (license (list license:agpl3+
> + ;; test/test.c is based on a public-domain test
> + license:public-domain))))
This looks okay to me, although the unusual order of package fields
really throws me off. We normally have “arguments” after “build-system”
(because they are arguments to the build-side code), “*inputs” below
“arguments”, “synopsis” above “description”, etc.
I also think all of psyc should go to “messaging” instead of getting its
own module.
~~ Ricardo
next prev parent reply other threads:[~2016-10-30 5:58 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-29 10:38 [PATCH 1/4] gnu: Add perl-net-psyc ng0
2016-09-29 10:38 ` [PATCH 2/4] gnu: Add libpsyc ng0
2016-10-30 5:57 ` Ricardo Wurmus [this message]
2016-09-29 10:38 ` [PATCH 3/4] gnu: Add psyclpc ng0
2016-10-30 6:03 ` Ricardo Wurmus
2016-10-30 12:46 ` ng0
2016-09-29 10:38 ` [PATCH 4/4] gnu: Add psyced ng0
2016-09-29 10:44 ` ng0
2016-10-30 5:42 ` Ricardo Wurmus
2016-10-30 5:48 ` Ricardo Wurmus
2016-10-02 1:46 ` [PATCH 1/4] gnu: Add perl-net-psyc Leo Famulari
2016-10-02 10:35 ` ng0
2016-10-04 2:24 ` Leo Famulari
2016-10-04 8:23 ` ng0
2016-10-04 8:34 ` psyc.scm: new patch series ng0
2016-10-04 8:34 ` [PATCH 1/4] gnu: Add perl-net-psyc ng0
2016-10-04 8:34 ` [PATCH 2/4] gnu: Add libpsyc ng0
2016-10-04 8:34 ` [PATCH 3/4] gnu: Add psyclpc ng0
2016-10-04 8:34 ` [PATCH 4/4] gnu: Add psyced ng0
2016-10-26 11:37 ` Efraim Flashner
2016-10-28 10:04 ` ng0
2016-10-30 5:54 ` [PATCH 1/4] gnu: Add perl-net-psyc Ricardo Wurmus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eg2y9y5d.fsf@mdc-berlin.de \
--to=ricardo.wurmus@mdc-berlin.de \
--cc=guix-devel@gnu.org \
--cc=ngillmann@runbox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).