Re: [PATCH] gnu: Add toxic.

[ng0 <ng0@libertad.pw>]

John Darrington <john@darrington.wattle.id.au> writes:

> On Thu, Dec 22, 2016 at 06:51:10PM -0500, Kei Kebreau wrote:
>      ng0 <ng0@libertad.pw> writes:
>      
>      > * gnu/packages/messaging.scm (toxic): New variable.
>      > ---
>      >  gnu/packages/messaging.scm | 47 ++++++++++++++++++++++++++++++++++++++++++++++
>      >  1 file changed, 47 insertions(+)
>      >
>      > +(define-public toxic
>      > +  (package
>      > +    (name "toxic")
>      > +    (version "0.7.2")
>      > +    (source
>      > +     (origin
>      > +       (method url-fetch)
>      > +       (uri (string-append "https://github.com/JFreegman/toxic/archive/"
>      > +                           "v" version ".tar.gz"))
>      > +       (sha256
>      > +        (base32
>      > +         "0nbcj71ffl85l396bxc5cs8d7abn4b7absaj5asq9bvcfv52m5m2"))
>      > +       (file-name (string-append name "-" version ".tar.gz"))))
>      > +    (inputs
>      > +     `(("ncurses" ,ncurses)
>      
>      I'm not sure what's up here. IIRC, we don't install the ncurses *.pc
>      files. If I'm wrong, someone please correct me.
>
> It would seem that we don't.  In fact so far as I'm aware, ncurses doesn't even
> provide such a thing.  Instead it provides it's own pkg-config like utility called
> "ncursesw60config" which you can use if you like.
>
> Personally however I don't like either approach.   I think it much cleaner and more
> reliably to explicitly state which path(s) and libraries you need rather than to 
> rely on some wierd script to guess it for you.
>      
> J'
>
> -- 
> Avoid eavesdropping.  Send strong encrypted email.
> PGP Public key ID: 1024D/2DE827B3 
> fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
> See http://sks-keyservers.net or any PGP keyserver for public key.
>

I have no preference. I just have no idea right now how to fix
the detection of ncurses here. If I would sit down for more than
a few hours with months apart I could come up with a solution,
but I'd rather use the collaborative approach and get review and
ideas from other people.
Kei: Thanks for solving the first part of the problem!

John: If we used absolute paths for every occurence of ncurses
related files in the build system of toxic, would this work? I
have no time to try this at the moment.
-- 
♥Ⓐ  ng0  | PGP keys and more: https://n0is.noblogs.org/
         |                    http://ng0.chaosnet.org