Re: [PATCH] gnu: Add emacs-ag

[Christopher Baines <mail@cbaines.net>]

[-- Attachment #1: Type: text/plain, Size: 1981 bytes --]

Alex Kost <alezost@gmail.com> writes:

> Christopher Baines (2017-01-15 11:25 +0000) wrote:
>
>> * gnu/packages/emacs.scm (emacs-ag): New variable.
>> ---
>>  gnu/packages/emacs.scm | 27 +++++++++++++++++++++++++++
>>  1 file changed, 27 insertions(+)
>>
>> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
>> index 50cea7685..6933dcc35 100644
>> --- a/gnu/packages/emacs.scm
>> +++ b/gnu/packages/emacs.scm
>> @@ -46,6 +46,7 @@
>>    #:use-module (guix build-system glib-or-gtk)
>>    #:use-module (guix build-system trivial)
>>    #:use-module (gnu packages)
>> +  #:use-module (gnu packages code)
>>    #:use-module (gnu packages guile)
>>    #:use-module (gnu packages gtk)
>>    #:use-module (gnu packages gnome)
>> @@ -1066,6 +1067,32 @@ like.  It can be linked with various Emacs mail clients (Message and Mail
>>  mode, Rmail, Gnus, MH-E, and VM).  BBDB is fully customizable.")
>>      (license license:gpl3+)))
>>  
>> +(define-public emacs-ag
>> +  (package
>> +    (name "emacs-ag")
>> +    (version "0.47")
>> +    (source (origin
>> +             (method url-fetch)
>> +             (uri (string-append
>> +                   "https://github.com/Wilfred/ag.el/archive/"
>> +                   version ".tar.gz"))
>> +             (file-name (string-append name "-" version ".tar.gz"))
>> +             (sha256
>> +              (base32
>> +               "1rlmp6wnyhqfg86dbz17r914msp58favn4kd4yrdwyia265a4lar"))))
>> +    (build-system emacs-build-system)
>> +    (propagated-inputs
>> +     `(("the-silver-searcher" ,the-silver-searcher)
>
> Is it propagated just because "ag" executable is needed?  If so, then
> it's better to keep it in 'inputs' and to change the value of
> 'ag-executable' variable (in "ag.el") using 'emacs-substitute-variables'.
> See 'emacs-slime', 'emacs-w3m', etc. for examples.

Ah, cool, I didn't know doing this was so easy before :) I've sent
another patch with this change.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 962 bytes --]