From: Marius Bakke <mbakke@fastmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 0/1] gnu: gcc@5: Make __DATE__ and __TIME__ macros reproducible.
Date: Mon, 23 Jan 2017 20:56:57 +0100 [thread overview]
Message-ID: <87efzt5z3q.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> (raw)
In-Reply-To: <874m0sl9el.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 816 bytes --]
Ludovic Courtès <ludo@gnu.org> writes:
>> They *should* be functionally identical to Debians patches:
>>
>> https://anonscm.debian.org/viewvc/gcccvs/branches/sid/gcc-5/debian/patches/
>>
>> ...but I have not verified this. Any takers?
>
> The ‘guix environment’ session you show is exactly how I would have
> tested it, so I don’t think there’s more to be tested, is there?
Was mostly afraid to have missed something, but I could not spot any
differences :)
> I’d only keep the subject line of the patch rather than the complete
> log, to keep it small. We have the upstream commit URL anyway.
>
> Apart from that, LGTM for ‘core-updates’.
OK, pushed with that change!
>
> Next we can remove all those __DATE__/__TIME__ snippets and dance!
>
> Thank you!
>
> Ludo’.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
prev parent reply other threads:[~2017-01-23 19:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-21 11:36 [PATCH 0/1] gnu: gcc@5: Make __DATE__ and __TIME__ macros reproducible Marius Bakke
2017-01-21 11:36 ` [PATCH 1/1] gnu: gcc@5: Respect SOURCE_DATE_EPOCH in __DATE__ and __TIME__ macros Marius Bakke
2017-01-21 15:28 ` [PATCH 0/1] gnu: gcc@5: Make __DATE__ and __TIME__ macros reproducible Ludovic Courtès
2017-01-23 19:56 ` Marius Bakke [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87efzt5z3q.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me \
--to=mbakke@fastmail.com \
--cc=guix-devel@gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).