From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?utf-8?Q?Cl=C3=A9ment?= Lassieur <clement@lassieur.org>
Subject: Re: [PATCH 3/4] services: openssh: Fix 'PrintLastLog' default
	behaviour.
Date: Thu, 02 Mar 2017 22:03:52 +0100
Message-ID: <87efyfxufb.fsf@lassieur.org>
References: <20170219185431.zgn53ndcbpedrgo7@wasp>
	<20170220235355.29115-1-clement@lassieur.org>
	<20170220235355.29115-4-clement@lassieur.org>
	<20170302083705.57339ace@scratchpost.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51520)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <clement@lassieur.org>) id 1cjXtG-0007Hv-Lu
	for guix-devel@gnu.org; Thu, 02 Mar 2017 16:03:59 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <clement@lassieur.org>) id 1cjXtD-0005Ns-Ic
	for guix-devel@gnu.org; Thu, 02 Mar 2017 16:03:58 -0500
Received: from mail.lassieur.org ([83.152.10.219]:36808)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <clement@lassieur.org>)
	id 1cjXtD-0005Mn-8T
	for guix-devel@gnu.org; Thu, 02 Mar 2017 16:03:55 -0500
In-reply-to: <20170302083705.57339ace@scratchpost.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: guix-devel@gnu.org

Danny Milosavljevic <dannym@scratchpost.org> writes:

> Hi,
>
> On Tue, 21 Feb 2017 00:53:54 +0100
> Cl=C3=A9ment Lassieur <clement@lassieur.org> wrote:
>
>> * gnu/services/ssh.scm (openssh-config-file): Add 'pring-last-log?' op=
tion.
>                                                          ^ typo

Done.

>>   (<openssh-configuration>)[print-last-log?]: Add it.
>>   (openssh-activation): Touch /var/log/lastlog.
>
> Indentation is too much here.

Done, on other patches too.

>> * doc/guix.texi (Networking Services): Document 'pring-last-log?'.
>                                                        ^ typo

Done.

>> +      (let ((lastlog "/var/log/lastlog"))
>> +        (when #$(openssh-configuration-print-last-log? config)
>> +          (unless (file-exists? lastlog)
>> +            (touch lastlog))))
>> +
>
> Hmm. What about the permissions? Are they OK?

The permissions are OK (644, root:root).

> Otherwise LGTM!

Thank you!

I'll answer this with the three openssh updated patches.