Re: 01/01: guix: git: Add new module.

Re: 01/01: guix: git: Add new module.

[Leo Famulari]

[-- Attachment #1: Type: text/plain, Size: 2868 bytes --]

On Fri, May 05, 2017 at 01:53:25PM -0400, Mathieu Othacehe wrote:
> mothacehe pushed a commit to branch master
> in repository guix.
> 
> commit a70b784708fb5e1b78430aa793d89ca04bc641a8
> Author: Mathieu Othacehe <m.othacehe@gmail.com>
> Date:   Fri May 5 11:01:50 2017 +0200
> 
>     guix: git: Add new module.
>     
>     * guix/git.scm: New file.
>     * configure.ac: Check for (guile git).
>     * Makefile.am: Build guix/git.scm if (guile git) is available.

This commit caused `guix pull` to fail:

------
copying and compiling to '/gnu/store/42nnrpz5n3yrf8x5vk75gf71ji20q86n-guix-latest'...
loading...       12.0% of 593 filesBacktrace:
In ice-9/boot-9.scm:
1734: 19 [%start-stack load-stack #<procedure 8f69c0 at ice-9/boot-9.scm:4080:10 ()>]
1739: 18 [#<procedure 8f86c0 ()>]
In unknown file:
   ?: 17 [primitive-load "/gnu/store/8mj3lxzrpicjdz8x702p5hgc1f8y1hhm-guix-latest-builder"]
In ./guix/build/pull.scm:
  57: 16 [build-guix "/gnu/store/42nnrpz5n3yrf8x5vk75gf71ji20q86n-guix-latest" ...]
 123: 15 [#<procedure c62280 at ./guix/build/pull.scm:57:2 ()>]
In ice-9/boot-9.scm:
2900: 14 [resolve-interface (guix git) #:select ...]
2825: 13 [#<procedure 84ec60 at ice-9/boot-9.scm:2813:4 (name #:optional autoload version #:key ensure)> # ...]
3101: 12 [try-module-autoload (guix git) #f]
2412: 11 [save-module-excursion #<procedure 3b3cc30 at ice-9/boot-9.scm:3102:17 ()>]
3121: 10 [#<procedure 3b3cc30 at ice-9/boot-9.scm:3102:17 ()>]
In unknown file:
   ?: 9 [primitive-load-path "guix/git" ...]
In ice-9/eval.scm:
 505: 8 [#<procedure 79b520 at ice-9/eval.scm:499:4 (exp)> (define-module # # ...)]
In ice-9/psyntax.scm:
1107: 7 [expand-top-sequence ((define-module (guix git) #:use-module ...)) () ...]
 990: 6 [scan ((define-module (guix git) #:use-module ...)) () ...]
 279: 5 [scan ((#(syntax-object let # ...) (#) (# #) ...)) () ...]
In ice-9/eval.scm:
 411: 4 [eval # ()]
In ice-9/boot-9.scm:
2987: 3 [define-module* (guix git) #:filename ...]
2962: 2 [resolve-imports (((git)) ((git object)) ((guix base32)) ...)]
2903: 1 [resolve-interface (git) #:select ...]
In unknown file:
   ?: 0 [scm-error misc-error #f "~A ~S" ("no code for module" (git)) #f]

ERROR: In procedure scm-error:
ERROR: no code for module (git)
builder for `/gnu/store/7j7i1vr3kmhjmkvcd3hislmjvbbzixrv-guix-latest.drv' failed with exit code 1
------

I could not reproduce the failure when building "by hand", but since
`guix pull` is the primary method of updating Guix, I reverted this
change for now:

https://git.savannah.gnu.org/cgit/guix.git/commit/?id=40d728a87d4b6993437ed33dbe2dcb47363ae7c0

Mathieu, can you take a look?

PS - It's possible to test `guix pull` locally like this:

$ git archive --prefix='guix/' --format=tar HEAD | gzip > /tmp/guix.tar.gz
$ guix pull --url=file:///tmp/guix.tar.gz

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: 01/01: guix: git: Add new module.

[Mathieu Othacehe]

Hi Leo,

Thanks for taking care of it.

> I could not reproduce the failure when building "by hand", but since
> `guix pull` is the primary method of updating Guix, I reverted this
> change for now:

I guess it is because in (guix build pull) every single file is
builded, without take configure/makefile consigns into account.

Except a horrible hack (an exception list in "build-guix"), I don't see
how to deal with it. Maybe this commit shall be put on a branch or wait
until guix switches to guile2.2.

Ludo any thoughs ?

Mathieu

Re: 01/01: guix: git: Add new module.

[Ludovic Courtès]

Hi,

Mathieu Othacehe <m.othacehe@gmail.com> skribis:

> Thanks for taking care of it.
>
>> I could not reproduce the failure when building "by hand", but since
>> `guix pull` is the primary method of updating Guix, I reverted this
>> change for now:
>
> I guess it is because in (guix build pull) every single file is
> builded, without take configure/makefile consigns into account.

Yes, see build-aux/build-self.scm.

> Except a horrible hack (an exception list in "build-guix"), I don't see
> how to deal with it. Maybe this commit shall be put on a branch or wait
> until guix switches to guile2.2.
>
> Ludo any thoughs ?

I plan to update ‘guix pull’ for Guile 2.2 before the release:

  https://lists.gnu.org/archive/html/guix-devel/2017-04/msg00515.html

When it’s done, we could add Guile-Git as an input when 2.2 is used, and
maybe add a special case for (guix git).

Thoughts?

Ludo’.

Re: 01/01: guix: git: Add new module.

[Mathieu Othacehe]

Hi Ludo,

> When it’s done, we could add Guile-Git as an input when 2.2 is used, and
> maybe add a special case for (guix git).
>
> Thoughts?

Yes I think, that's our best option :) I'll resubmit this patch later
then !

Thanks,

Mathieu