From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: GRUB EFI installation breakage
Date: Tue, 22 Aug 2017 15:34:54 +0200
Message-ID: <87efs34tfl.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55797)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1dk9Kq-0000sU-9P
	for guix-devel@gnu.org; Tue, 22 Aug 2017 09:35:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1dk9Kj-0007kb-De
	for guix-devel@gnu.org; Tue, 22 Aug 2017 09:35:11 -0400
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Andy Wingo <wingo@igalia.com>
Cc: guix-devel <guix-devel@gnu.org>

--=-=-=
Content-Type: text/plain

Hello,

To reconfigure my system on UEFI, I had to apply this patch:


--=-=-=
Content-Type: text/x-patch
Content-Disposition: inline

modified   gnu/bootloader/grub.scm
@@ -401,7 +401,8 @@ submenu \"GNU system, old configurations...\" {~%")
         ;; root partition.
         (setenv "GRUB_ENABLE_CRYPTODISK" "y")
         (unless (zero? (system* grub-install "--boot-directory" install-dir
-                                "--efi-directory" efi-dir))
+                                ;; "--efi-directory" efi-dir
+                                ))
           (error "failed to install GRUB (EFI)")))))
 

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


Before that =E2=80=98grub-install=E2=80=99 would fail because =E2=80=98efi-=
dir=E2=80=99 would actually
be =E2=80=9C/dev/sda=E2=80=9D, which is what I have in the =E2=80=98device=
=E2=80=99 field of
=E2=80=98grub-configuration=E2=80=99.

Removing the =E2=80=9C--efi-directory=E2=80=9D solves the problem because =
=E2=80=98grub-install=E2=80=99
automatically determines that the EFI directory is mounted at /boot/efi.

I think 2941b347b664a3d3114de0ac95e28db78db66144 is bogus because it
assumes that the second argument of the gexp=E2=80=99d lambda is =E2=80=98e=
fi-dir=E2=80=99,
where in fact it is the =E2=80=98device=E2=80=99 field of the bootloader co=
nfig.

So what is the preferred fix?  Simply remove =E2=80=9C--efi-directory=E2=80=
=9D like I
did above, and rename =E2=80=98efi-dir=E2=80=99 to =E2=80=98device=E2=80=99=
 to avoid the ambiguity?
Thoughts?

Ludo=E2=80=99.

--=-=-=--