From mboxrd@z Thu Jan  1 00:00:00 1970
From: iyzsong@member.fsf.org (=?utf-8?B?5a6L5paH5q2m?=)
Subject: Re: Package for LXQt. Help wanted.
Date: Fri, 26 Oct 2018 22:24:58 +0800
Message-ID: <87efccpyyt.fsf@member.fsf.org>
References: <87va5ushnh.fsf@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58224)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <iyzsong@member.fsf.org>) id 1gG3CX-0001X4-E0
	for guix-devel@gnu.org; Fri, 26 Oct 2018 10:35:02 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <iyzsong@member.fsf.org>) id 1gG3CT-0001Cl-F1
	for guix-devel@gnu.org; Fri, 26 Oct 2018 10:35:01 -0400
Received: from rezeros.cc ([45.76.207.221]:36898)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <iyzsong@member.fsf.org>)
	id 1gG3CS-00019Q-Uo
	for guix-devel@gnu.org; Fri, 26 Oct 2018 10:34:57 -0400
In-Reply-To: <87va5ushnh.fsf@gmail.com> (Meiyo Peng's message of "Mon, 22 Oct
	2018 12:57:06 +0800")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Meiyo Peng <meiyo.peng@gmail.com>
Cc: guix-devel@gnu.org

Meiyo Peng <meiyo.peng@gmail.com> writes:

> Hello everyone,
>
> I made a series of packages for LXQt. The code is at:
> https://github.com/meiyopeng/guix/tree/lxqt

Hello, thank you again, I have push them!

With some minor edits:

- Add comments about the missing translations (disable the
  PULL_TANSLATIONS), which are in the lxqt-l10n git repository.  I think
  we can prefetch it as a 'origin', add it to the input of the
  application, or add a 'lxqt-l10n' package.

- Correct some licenses, eg: obconf-qt, qps are under GPL2+.


And a "lxqt-build-tools: Dedifen LXQT_*_DIR variables" patch is
unapplied:

     (build-system cmake-build-system)
     (arguments
-     `(#:tests? #f))                    ; no tests
+     `(#:tests? #f  ;; no tests
+       #:configure-flags
+       `("-DLXQT_DATA_DIR=/run/current-system/profile/share"
+         "-DLXQT_ETC_XDG_DIR=/run/current-system/profile/etc/xdg")))

What are thoses variables used for?  If I install the 'lxqt' package
into my user profile, should I set them to the directories under my
profile ($HOME/.guix-profile/share and $HOME/.guix-profile/etc/xdg)?