From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id QO4UK0fBW19PSQAA0tVLHw (envelope-from ) for ; Fri, 11 Sep 2020 18:26:15 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id oLF+JUfBW18BSQAA1q6Kng (envelope-from ) for ; Fri, 11 Sep 2020 18:26:15 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E306A940215 for ; Fri, 11 Sep 2020 18:26:14 +0000 (UTC) Received: from localhost ([::1]:40520 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kGnkT-0007pC-Ty for larch@yhetil.org; Fri, 11 Sep 2020 14:26:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57840) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kGnkJ-0007p2-T9 for guix-devel@gnu.org; Fri, 11 Sep 2020 14:26:03 -0400 Received: from mail-qt1-x844.google.com ([2607:f8b0:4864:20::844]:38070) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kGnkH-0000PR-7I for guix-devel@gnu.org; Fri, 11 Sep 2020 14:26:03 -0400 Received: by mail-qt1-x844.google.com with SMTP id c18so8640388qtw.5 for ; Fri, 11 Sep 2020 11:26:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=rHF7ULFKSXIa8STP+keCSIWBarzAgku2HZU7/5FGSGE=; b=A5453k7rqcl+HU2OGOWzRAlT+rhCeC6KjYNJH0+6xdBVUh7zNondnsnWjI5LHC/3dc xM8QK6mraK9G+s1EDeVrVMFws87O9a1tQLKMnwmlCk24eH0kb4yyD/TIsdjrv5rLJt0O V78U/p0I5l4byx9p9qebv6YazmP1x1FjSKEebRZOD0HsDrVh0q1gYTm5OTU5VnRmZ6tE k6BU3SdCup0PVM5ZOg27Cr0i+tdpFdSxSIAa2ViHmwf1K/G0bXgG+6tgl26LpgtKVVUk p9MRX2LYWfoMWC57cjheao95bkjEG20lrY1Ez2nEAVO9TbFflSteVm7MCrmEvVsuFkyw Okbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=rHF7ULFKSXIa8STP+keCSIWBarzAgku2HZU7/5FGSGE=; b=ruOHsLBnFrDUF44daNFjUBlsJVrVrzJ0gz7GfjWDA9eEhtOYCYUGwLrUG3sZhaLLDv JQrOLsPYj0i+Bpn4RphpXDMc429fcIk7RxPMY3OI221+ejtf25LVwRQ8kir0moPbrAls eg6xj3vNymIxInljf0tGltN13vEHIhVc20+E3oVEXCKqU8MsrbboIjhYW8/4jqFf410i /HI+isg9PbFrMgGTylo8BR+wsk7TZzuHfsX9DUVqWTkInhRg8c/UI9d0wkfy/YB8Siww hkubrpX8GpdKRMmGgfFnrWH5E5VfrEiXfrJXY8bYlK9465vKvjTEbYllMPH1Z3lXhBqi L5ig== X-Gm-Message-State: AOAM530YECvChdyRAaW9XjsCnhepsXPeLf+bE0bxqEz82DuM5ttL3uOM GUDU+2EgQASCzQm5YE6N6gBHR0qD+kMutQ== X-Google-Smtp-Source: ABdhPJwzN33VvyQn56iG0YCe6rWf6eSmcO3ibi02niF2/7k7B9rcAhKiscS1iyVNdBc8MrFWxzFHWw== X-Received: by 2002:aed:3b95:: with SMTP id r21mr3213226qte.368.1599848760015; Fri, 11 Sep 2020 11:26:00 -0700 (PDT) Received: from hurd (dsl-10-146-200.b2b2c.ca. [72.10.146.200]) by smtp.gmail.com with ESMTPSA id u17sm3435135qtq.20.2020.09.11.11.25.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Sep 2020 11:25:59 -0700 (PDT) From: Maxim Cournoyer To: Mark H Weaver Subject: Re: What should "guix build --source" produce? (was Re: Dependency cycle issues when using a Gexp-based snippet) References: <87h7ssx07p.fsf@gmail.com> <87lfhkj4hr.fsf@netris.org> Date: Fri, 11 Sep 2020 14:26:40 -0400 In-Reply-To: <87lfhkj4hr.fsf@netris.org> (Mark H. Weaver's message of "Tue, 08 Sep 2020 00:07:01 -0400") Message-ID: <87een86ufz.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::844; envelope-from=maxim.cournoyer@gmail.com; helo=mail-qt1-x844.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: guix-devel Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=A5453k7r; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Spam-Score: -1.71 X-TUID: YIbxSFMMn2wq Hi Mark, Mark H Weaver writes: > Hi Maxim, > > maxim.cournoyer@gmail.com writes: > >> While trying to move some of the patching done to qtbase into a snippet, >> with the goal of having at least the ./configure script runnable in a >> guix environment without having to manually run patching phases: > > [...] > >> + (snippet >> + (with-imported-modules '((guix build utils)) >> + #~(begin >> + (use-modules (guix build utils)) >> + ;; corelib uses bundled harfbuzz, md4, md5, sha3 >> + (with-directory-excursion "src/3rdparty" >> + (for-each delete-file-recursively >> + (list "double-conversion" "freetype" "harfbuzz-ng" >> + "libpng" "libjpeg" "pcre2" "sqlite" "xcb" >> + "zlib"))) >> + >> + (let ((coreutils #+(canonical-package coreutils))) >> + (substitute* "configure" >> + (("/bin/pwd") >> + (string-append coreutils "/bin/pwd"))) >> + (substitute* "src/corelib/global/global.pri" >> + (("/bin/ls") >> + (string-append coreutils "/bin/ls")))) >> + #t))))) > > Apart from the technical difficulties with cyclic modules, I'd like to > raise another issue. > > In my opinion, "guix build --source PACKAGE" should produce sources that > can be used to build the package on any system that the upstream package > supports, not just on Guix systems. > > Alternatively, Guix should at least have *some* command to do this. > > Such a command would be especially useful for packages that we clean for > FSDG compliance. For example, I've made sure that "guix build --source > icecat" produces a tarball that's suitable for any system that IceCat > supports, and incidentally I intend to use Guix to generate the official > IceCat source tarballs. > > Such a command would be useful for 'ungoogled-chromium' as well, and for > many of our other packages that include snippets to remove > non-FSDG-compliant code. > > The snippet that you proposed above would produce "sources" that can > only be built on Guix systems, and moreover, only on the same > architecture and core-updates cycle that produced it. > > I think that we ought to think about what "corresponding sources" should > be, and put some care into making sure that "guix build --source" > produces something worthy of that name. > > What do you think? Thanks for those insightful remarks about what the source returned by 'guix build --source' should be. I agree with you, and as Andreas pointed, your remarks seem useful in drawing the distinction between when to use snippets vs build phases. Maxim